Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PepperBridgeAbstract,DealabsBridge,HotUKDealsBridge,MydealsBridge] Fix search URL, No results handling fixed, Thread title and Message URL handling #4053

Merged
merged 2 commits into from
Apr 4, 2024

Conversation

sysadminstory
Copy link
Contributor

Search URL has been updated according to the website.

If a search doesn't return any results, the HTML won't contain any
specific text now : the HTML structure is slightly different, so the
bridge has been updated.

The unnneded 'no-results' text is now removed from the specific bridges.

The board thread title has been removed from the content, so now we use
the page <title> element.

In case a board message is empty, there was an exception during the
filtering of message without URL.

…ix search URL, No results handling fixed, Thread title and Message URL handling

Search URL has been updated according to the website.

If a search doesn't return any results, the HTML won't contain any
specific text now : the HTML structure is slightly different, so the
bridge has been updated.

The unnneded 'no-results' text is now removed from the specific bridges.

The board thread title has been removed from the content, so now we use
the page <title> element.

In case a board message is empty, there was an exception during the
filtering of message without URL.
…ix search URL, No results handling fixed, Thread title and Message URL handling

Coding policy fixes
Copy link

github-actions bot commented Apr 3, 2024

Pull request artifacts

Bridge Context Status
Dealabs 1 Recherche par Mot(s) clé(s) (current) ✔️
Dealabs 1 Recherche par Mot(s) clé(s) (pr) ✔️
Dealabs 2 Deals par groupe (current) ✔️
Dealabs 2 Deals par groupe (pr) ⚠️ The feed has no items
Dealabs 3 Surveillance Discussion (current) ⚠️ WARNING Attempt to read property "plaintext" on null at bridges/PepperBridgeAbstract.php line 267
Dealabs 3 Surveillance Discussion (pr) ✔️
HotUKDeals 1 Search by keyword(s)) (current) ✔️
HotUKDeals 1 Search by keyword(s)) (pr) ✔️
HotUKDeals 2 Deals per group (current) ✔️
HotUKDeals 2 Deals per group (pr) ⚠️ The feed has no items
HotUKDeals 3 Discussion Monitoring (current) ⚠️ WARNING Attempt to read property "plaintext" on null at bridges/PepperBridgeAbstract.php line 267
HotUKDeals 3 Discussion Monitoring (pr) ✔️
Mydeals 1 Suche nach Stichworten (current) ✔️
Mydeals 1 Suche nach Stichworten (pr) ✔️
Mydeals 2 Deals pro Gruppen (current) ✔️
Mydeals 2 Deals pro Gruppen (pr) ⚠️ The feed has no items
Mydeals 3 Überwachung Diskussion (current) ⚠️ WARNING Attempt to read property "plaintext" on null at bridges/PepperBridgeAbstract.php line 267
Mydeals 3 Überwachung Diskussion (pr) ✔️

last change: Wednesday 2024-04-03 21:37:19

@dvikan dvikan merged commit 82606a4 into RSS-Bridge:master Apr 4, 2024
7 checks passed
@sysadminstory sysadminstory deleted the pepperbridge-fix-search branch April 4, 2024 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants