Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IdealoBridge] Fix Feed items & Feed title customisation #4013

Merged
merged 1 commit into from
Mar 13, 2024

Conversation

sysadminstory
Copy link
Contributor

  • Feed items with new price tracking had "Max Price Used" instead of "Max Price New"
  • Feed Title is now customised with the product name and the Price limits
  • Fixed logic for saving prices in cache
  • remove undefined variable notices

- Feed items with new price tracking had "Max Price Used" instead of
  "Max Price New"
- Feed Title is now customised with the product name and the Price
  limits
- Fixed logic for saving prices in cache
- remove undefined variable notices
Copy link

Pull request artifacts

Bridge Context Status
Idealo 1 untitled (current) ⚠️ WARNING Undefined variable $title at bridges/IdealoBridge.php line 146
Idealo 1 untitled (pr) ✔️

last change: Wednesday 2024-03-13 21:54:23

@dvikan dvikan merged commit e6cb5fd into RSS-Bridge:master Mar 13, 2024
7 checks passed
@dvikan
Copy link
Contributor

dvikan commented Mar 13, 2024

you can use $this->cache in bridges.

@sysadminstory sysadminstory deleted the fix-idealo branch March 25, 2024 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants