Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ComicsKingdomBridge] Fix/Rewrite of ComicsKingdom Bridge #4003

Merged
merged 3 commits into from
Mar 10, 2024

Conversation

TReKiE
Copy link
Contributor

@TReKiE TReKiE commented Mar 10, 2024

A rewrite of the ComicsKingdom bridge as the existing one hasn't worked in over a week after the site was redesigned again.

  • Now uses REST API
  • Added optional limit to get desired number of comics
  • Feed name and comic titles now pulled from site
  • Added myself as the maintainer as I've been the one maintaining, and the existing code is no longer used

Rewrite of bridge as the existing one no longer works:
- Now uses REST API
- Added optional limit to get desired number of comics
- Author now reflects the comic creators name
- Feed name and comic titles now pulled from site
- Added myself as the maintainer as I've been the one maintaining, and the existing code no longer is used
Copy link

github-actions bot commented Mar 10, 2024

Pull request artifacts

Bridge Context Status
ComicsKingdom 1 untitled (current) HTTP status 500 Internal Server Error
Type: Error
Message: Call to a member function getTimestamp() on bool
⚠️ (shutdown) 8192: Creation of dynamic property simple_html_dom::$optional_closing_array is deprecated in lib/simplehtmldom/simple_html_dom.php line 1495
ComicsKingdom 1 untitled (pr) ✔️

last change: Sunday 2024-03-10 04:37:15

@dvikan dvikan merged commit 84b93e0 into RSS-Bridge:master Mar 10, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants