Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CssSelectorComplexBridge: Use cookies everywhere (#3827) #3870

Merged
merged 1 commit into from
Jan 9, 2024
Merged

CssSelectorComplexBridge: Use cookies everywhere (#3827) #3870

merged 1 commit into from
Jan 9, 2024

Conversation

ORelio
Copy link
Contributor

@ORelio ORelio commented Dec 30, 2023

Fixes #3827

@github-actions GitHub Actions
Copy link

Pull request artifacts

Bridge Context Status
CssSelectorComplex 1 untitled (current) ❌ Bridge returned error 404! (19721)
❌ Type: HttpException
❌ Message: https://example.com/blog/ resulted in 404 Not Found <!doctype html>
CssSelectorComplex 1 untitled (pr) ❌ Bridge returned error 404! (19721)
❌ Type: HttpException
❌ Message: https://example.com/blog/ resulted in 404 Not Found <!doctype html>

last change: Saturday 2023-12-30 10:03:58

@ORelio ORelio mentioned this pull request Dec 30, 2023
Closed
@ORelio
Copy link
Contributor Author

ORelio commented Dec 30, 2023

Suggested reviewer: @LarsStegman

@LarsStegman
Copy link
Contributor

LarsStegman commented Dec 30, 2023 •
edited
Loading

I haven't run the code, but this is a good change. Do you want me to run it? If so, is there a docker image published for this branch?

@dvikan
Copy link
Contributor

dvikan commented Dec 30, 2023

download this patch and apply it:

wget -O /tmp/3870.patch "https://github.com/RSS-Bridge/rss-bridge/pull/3870.patch"
git apply /tmp/3870.patch

@dvikan
Copy link
Contributor

dvikan commented Jan 9, 2024

looks good i guess. havent tested it.

@dvikan dvikan merged commit 0c08f79 into RSS-Bridge:master Jan 9, 2024
7 checks passed
@dvikan
Copy link
Contributor

dvikan commented Jan 9, 2024

oopsie. this generates error.

the second argument is $ttl and must be an int

@ORelio

dvikan added a commit to dvikan/rss-bridge that referenced this pull request Jan 9, 2024
@dvikan
Revert "CssSelectorComplexBridge: Use cookies everywhere (RSS-Bridge#…
3d804cb 
…3827) (RSS-Bridge#3870)"

This reverts commit 0c08f79.
dvikan added a commit that referenced this pull request Jan 9, 2024
@dvikan
Revert "CssSelectorComplexBridge: Use cookies everywhere (#3827) (#3870…
1fecc4c 
…)" (#3881)

This reverts commit 0c08f79.
@ORelio ORelio mentioned this pull request Jan 10, 2024
Merged
dvikan pushed a commit that referenced this pull request Jan 10, 2024
@ORelio
CssSelectorComplexBridge: Use cookies everywhere (#3827) (#3886)
c7e8ddf 
v2 after feedback from #3870
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[CssSelectorComplexBridge] Load article from page using provided cookie
3 participants
@ORelio @LarsStegman @dvikan