Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CNET News feed broken #3764

Closed
sebastien-maillard opened this issue Oct 17, 2023 · 3 comments
Closed

CNET News feed broken #3764

sebastien-maillard opened this issue Oct 17, 2023 · 3 comments
Labels
Bug-Report Confirmed bug report

Comments

@sebastien-maillard
Copy link

Generating the feed for CNET News either returns an empty feed or generates an error, depending on the topic selected.

To Reproduce
Steps to reproduce the behavior:

  1. Go to the CNET News section on https://rss-bridge.org/bridge01/
  2. Click on 'Generate feed'
  3. The feed is empty

Alternate issue:

  1. Select the topic 'Sci->Tech'
  2. Click on 'Generate feed'
  3. The following error message is displayed
Details
Type: Exception
Code: 400
Message: Invalid topic: topics/sci/tech
File: lib/utils.php
Line: 242
Trace
#0 index.php(61): RssBridge->main()
#1 lib/RssBridge.php(57): DisplayAction->execute()
#2 actions/DisplayAction.php(71): DisplayAction->createResponse()
#3 actions/DisplayAction.php(106): CNETBridge->collectData()
#4 bridges/CNETBridge.php(54): returnClientError()
#5 lib/utils.php(242)

Context
Query: action=display&bridge=CNETBridge&topic=topics-sci-tech&format=Html
Version: 2023-09-24 (git.master.ef5bd83)
OS: Linux
PHP: 7.4.33 

Expected behavior
A feed should be displayed instead of an empty feed or an error.

@sebastien-maillard sebastien-maillard added the Bug-Report Confirmed bug report label Oct 17, 2023
@dvikan
Copy link
Contributor

dvikan commented Oct 17, 2023

for the record there is also https://www.cnet.com/rss/news/

edit: sorry their feed is full of spam

@ORelio

@ORelio
Copy link
Contributor

ORelio commented Oct 18, 2023

Thanks for opening this bug report.
It seems like the bridge is completely broken, and CNET's own RSS feed contains broken links.
It's been a while since I stopped using that bridge and I think nobody else was using it.
Rewrote a new version for you in pull request #3770.
Not sure I'll keep maintaining it, but at least it works for now.

dvikan pushed a commit that referenced this issue Oct 18, 2023
Bridge was broken.
Full bridge rewrite using Sitemap as source.
@dvikan
Copy link
Contributor

dvikan commented Oct 18, 2023

thanks @ORelio

@dvikan dvikan closed this as completed Oct 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug-Report Confirmed bug report
Projects
None yet
Development

No branches or pull requests

3 participants