Improve test stability #4
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* limit multimethod version to 2.0 and earlier * add multimethod version to other settings * [makedocs] update installer download link * [makedocs] update branch docs
* use libmamba solver * add permissions [makedocs] * add write permission for dev docs [makedocs] * conda-solver: classic
…vitySim#901) Co-authored-by: Jeffrey Newman <[email protected]>
* use libmamba solver * add permissions [makedocs] * add write permission for dev docs [makedocs] * conda-solver: classic * include workflow dispatch option for tests * update release instructions * add installer build to instructions * Pin mamba for now, per conda-incubator/setup-miniconda#392 * conda-remove-defaults
…on_enhancements # Conflicts: # conda-environments/activitysim-dev-base.yml # conda-environments/activitysim-dev.yml # conda-environments/docbuild.yml # conda-environments/github-actions-tests.yml # pyproject.toml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes to the
activitysim/estimationmodule, primarily focusing on updating thelarchversion handling, modifying test cases, and adjusting model parameters.The key change is applying a constraint on the trip model choice model, to solve an over specification problem and ensure the estimation results are stable.
The most important changes are grouped by their themes below.
Test Case Adjustments:
test_location_modelfunction to lock a parameter and set a cap for the "trip_destination" model to ensure model identifiability.test_simple_simulatefunction inactivitysim/estimation/test/test_larch_estimation.pyto also use the "SLSQP" method for the "trip_destination" model. The SLSQP algorithm obeys constraints on parameter values, while the BHHH algorithm does not, yielding very different answers. Which is "better" depends on the modeler's opinion on the validity of the constraints.Version Handling:
larchversion check inactivitysim/estimation/larch/__init__.pyto handle development versions correctly.Model Parameter Updates:
test_loc_trip_destination_BHHH_loglike.csvandtest_loc_trip_destination_SLSQP_loglike.csvto reflect new model results. [1] [2]test_loc_trip_destination_SLSQP_size_spec.csv.CSV File Updates:
test_location_model_trip_destination_BHHH_None_.csvto reflect new model results.test_location_model_trip_destination_SLSQP_None_.csvwith updated parameter values for the "trip_destination" model.