fix mod menu highlight (for real this time)

also fixes highlight bugs with S1/2 level select and other text menus
RSDKModding · Feb 13, 2025 · 9a7220e · 9a7220e
1 parent cf532d7
commit 9a7220e
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 5 deletions.
diff --git a/RSDKv4/Debug.cpp b/RSDKv4/Debug.cpp
@@ -569,6 +569,7 @@ void SetTextMenu(int sm)
                 StrAdd(buffer, ": ");
                 StrAdd(buffer, modList[m].active ? "  Active" : "Inactive");
                 AddTextMenuEntry(&gameMenu[1], buffer);
+                gameMenu[1].entryHighlight[m] = false;
             }
 
             gameMenu[1].alignment      = 1;

diff --git a/RSDKv4/Text.cpp b/RSDKv4/Text.cpp
@@ -248,7 +248,6 @@ void AddTextMenuEntry(TextMenu *menu, const char *text)
 {
     menu->entryStart[menu->rowCount]     = menu->textDataPos;
     menu->entrySize[menu->rowCount]      = 0;
-    menu->entryHighlight[menu->rowCount] = false;
     int textLength                       = StrLength(text);
     for (int i = 0; i < textLength;) {
         if (text[i] != '\0') {
@@ -266,7 +265,6 @@ void AddTextMenuEntryW(TextMenu *menu, const ushort *text)
 {
     menu->entryStart[menu->rowCount]     = menu->textDataPos;
     menu->entrySize[menu->rowCount]      = 0;
-    menu->entryHighlight[menu->rowCount] = false;
     int textLength                       = StrLengthW(text);
     for (int i = 0; i < textLength;) {
         if (text[i] != '\0') {
@@ -284,7 +282,6 @@ void SetTextMenuEntry(TextMenu *menu, const char *text, int rowID)
 {
     menu->entryStart[rowID]              = menu->textDataPos;
     menu->entrySize[rowID]               = 0;
-    menu->entryHighlight[menu->rowCount] = false;
     int textLength                       = StrLength(text);
     for (int i = 0; i < textLength;) {
         if (text[i] != '\0') {
@@ -301,7 +298,6 @@ void SetTextMenuEntryW(TextMenu *menu, const ushort *text, int rowID)
 {
     menu->entryStart[rowID]              = menu->textDataPos;
     menu->entrySize[rowID]               = 0;
-    menu->entryHighlight[menu->rowCount] = false;
     int textLength                       = StrLengthW(text);
     for (int i = 0; i < textLength;) {
         if (text[i] != '\0') {
@@ -318,7 +314,6 @@ void EditTextMenuEntry(TextMenu *menu, const char *text, int rowID)
 {
     int entryPos                         = menu->entryStart[rowID];
     menu->entrySize[rowID]               = 0;
-    menu->entryHighlight[menu->rowCount] = false;
     int textLength                       = StrLength(text);
     for (int i = 0; i < textLength;) {
         if (text[i] != '\0') {