Problem with global external dependency #15
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm trying to use global external dependency via external option.
I got two problem:
modules declared as external could not be found by node_resolve, and it throws an exception. I solved this adding
exports.getNodePathExternal
in pathUtils.js. This solve my problem, but I doubt that could be by accident (I think an external module should not be passed to node_resolve at all, but I was not able to find a way)ast generated for global external module was rendered as
while the correct code is:
But please confirm that this change doesn't break amd external...