Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix no color in yaml key #30

Closed
wants to merge 1 commit into from
Closed

Fix no color in yaml key #30

wants to merge 1 commit into from

Conversation

budimanjojo
Copy link

@RRethy
Copy link
Owner

RRethy commented Nov 30, 2021

These colours are based on base16 spec. TSField is used in more languages than just YAML, it will have a large impact on highlighting.

@RRethy RRethy closed this Nov 30, 2021
@budimanjojo
Copy link
Author

Sorry, but I don't quite understand about base16 spec. Because I'm using the same base16 theme (https://github.com/chriskempson/base16-vim) in my other machine and the key in yaml is not white at all. The difference is I'm not using Treesitter on my other machine. Does this mean Treesitter is the one using TSField wrong? Should I open an issue there?

@RRethy
Copy link
Owner

RRethy commented Nov 30, 2021

There's no good solution but IMO the keys in YAML shouldn't be TSField. This would be the code that handles that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feature: more colour please
2 participants