Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Please restore master branch #20

Open
rzr opened this issue Nov 18, 2021 · 6 comments
Open

Please restore master branch #20

rzr opened this issue Nov 18, 2021 · 6 comments

Comments

@rzr
Copy link

rzr commented Nov 18, 2021 •
edited
Loading

Hi,

It looks like master branch have been removed recently ? do you confirm ? Is it intentional or a mistake ?

I am asking because other projects are (were) referring to it:
https://github.com/agherzan/meta-raspberrypi/blob/7413c72dd538d3956600211326a1c2ef01b8e057/recipes-kernel/linux-firmware-rpidistro/linux-firmware-rpidistro_git.bb#L37

Should reference be updated to align to debian named branches (IMHO tags would be good to use too).

If "master" is not an acceptable name, may I suggest then to use "main" , then it could be easier to alias/sed for downstream/legacy.

Any recommendations welcome.

Thx

Relate-to: YoeDistro/yoe-distro#617
Relate-to: agherzan/meta-raspberrypi@4c76dab
Cc: @agherzan
rzr referenced this issue in agherzan/meta-raspberrypi Nov 18, 2021
@kraj @agherzan
linux-firmware-rpidistro: Use bullseye branch
4c76dab 
Switch to using bullseye release 20210315-3+rpt3
License is pointed in different location in new repo structure WHENCE
file is gone too.

Fixes
YoeDistro/yoe-distro#617

Signed-off-by: Khem Raj <[email protected]>
landgraf added a commit to landgraf/meta-raspberrypi that referenced this issue Nov 18, 2021
@landgraf
Use bullseye branch instead of master
8106a81 
Master branch has been dropped and bullseye became the main branch of
the project.
This is not the cherry-pick of 3912f5b5 because mentioned commit brings
firmware version changes and updates the revision so not a candidate for
dunfell

Related: RPi-Distro/firmware-nonfree#20
Signed-off-by: Pavel Zhukov <[email protected]>
landgraf added a commit to landgraf/meta-raspberrypi that referenced this issue Nov 18, 2021
@landgraf
Use bullseye branch instead of master
d08d477 
Master branch has been dropped and bullseye became the main branch of
the project.
This is not the cherry-pick of 3912f5b5 because mentioned commit brings
firmware version changes and updates the revision so not a candidate for
dunfell

Related: RPi-Distro/firmware-nonfree#20
Signed-off-by: Pavel Zhukov <[email protected]>
@landgraf landgraf mentioned this issue Nov 18, 2021
Merged
@XECDesign
Copy link
Member

XECDesign commented Nov 18, 2021 •
edited
Loading

The previous master branch was renamed to buster, but I'd recommend switching over to bullseye. It's structured a bit differently, so some paths would need to be updated too.

landgraf added a commit to landgraf/meta-raspberrypi that referenced this issue Nov 18, 2021
@landgraf
linux-firmware-rpidistro: Use buster branch instead of master
fa768d9 
Master branch has been renamed to buster.
This change is dunfell-specific because master follows bullseye which
diverted from ex-master quite a lot.

Related: RPi-Distro/firmware-nonfree#20
Signed-off-by: Pavel Zhukov <[email protected]>
agherzan pushed a commit to agherzan/meta-raspberrypi that referenced this issue Nov 19, 2021
@landgraf @agherzan
linux-firmware-rpidistro: Use buster branch instead of master
934064a 
Master branch has been renamed to buster.
This change is dunfell-specific because master follows bullseye which
diverted from ex-master quite a lot.

Related: RPi-Distro/firmware-nonfree#20
Signed-off-by: Pavel Zhukov <[email protected]>
tewarid pushed a commit to tewarid/meta-raspberrypi that referenced this issue Nov 19, 2021
@landgraf @tewarid
linux-firmware-rpidistro: Use buster branch instead of master
4231976 
Master branch has been renamed to buster.
This change is dunfell-specific because master follows bullseye which
diverted from ex-master quite a lot.

Related: RPi-Distro/firmware-nonfree#20
Signed-off-by: Pavel Zhukov <[email protected]>
Signed-off-by: Devendra Tewari <[email protected]>
agherzan pushed a commit to agherzan/meta-raspberrypi that referenced this issue Nov 20, 2021
@landgraf @agherzan
linux-firmware-rpidistro: Use buster branch instead of master
0dc08f9 
Master branch has been renamed to buster.
This change is dunfell-specific because master follows bullseye which
diverted from ex-master quite a lot.

Related: RPi-Distro/firmware-nonfree#20
Signed-off-by: Pavel Zhukov <[email protected]>
Signed-off-by: Devendra Tewari <[email protected]>
duvallee added a commit to duvallee/yocto_project_raspberrypi that referenced this issue Nov 23, 2021
@duvallee
merge in 2021-11-23
b3b78c3 
commit 934064a01903b2ba9a82be93b3f0efdb4543a0e8 (HEAD -> dunfell, origin/dunfell)
Author: Pavel Zhukov <[email protected]>
Date:   Thu Nov 18 15:56:20 2021 +0100

    linux-firmware-rpidistro: Use buster branch instead of master

    Master branch has been renamed to buster.
    This change is dunfell-specific because master follows bullseye which
    diverted from ex-master quite a lot.

    Related: RPi-Distro/firmware-nonfree#20
    Signed-off-by: Pavel Zhukov <[email protected]>

commit 2e704f5ef61e4efd4b691a2ed1cad7a59811c791
Author: Changqing Li <[email protected]>
Date:   Thu May 13 11:15:47 2021 +0800

    99-com.rules: fix error invalid substitution type

    fix below error:
    /etc/udev/rules.d/99-com.rules:10 Invalid value "/bin/sh -c
    'ALIASES=/proc/device-tree/aliases; if cmp -s $ALIASES/uart0
    $ALIASES/serial0; then echo 0;elif cmp -s $ALIASES/uart0
    $ALIASES/serial1; then echo 1; else exit 1; fi'" for PROGRAM (char 58:
    invalid substitution type)

    Signed-off-by: Changqing Li <[email protected]>
    (cherry picked from commit fb253346c2fe85f8fdd49e5a66dff04d8f2bd53e)
    Signed-off-by: Pavel Zhukov <[email protected]>
@ArGJolan ArGJolan mentioned this issue Dec 1, 2021
Merged
@korya
Copy link

korya commented Dec 6, 2021

This change caused our build to start fail as well. We use https://git.yoctoproject.org/meta-raspberrypi. I assume we will have to upgrade it now.

Is there an easy way to change SRC_URI in https://git.yoctoproject.org/meta-raspberrypi/tree/recipes-kernel/linux-firmware-rpidistro/linux-firmware-rpidistro_git.bb?h=dunfell#n36 via .bbapend? I would like to avoid upgrading the whole meta-raspberrypi.

@XECDesign
Copy link
Member

The master branch was quite different to the currently maintained bullseye branch, so a change to would be required anyway.

Given that this repo was intended for the Debian package, it's a bit hard to use it as a stable source for third parties. We'll have issues again when bookworm comes out.

@pelwell Would it make sense to have a separate repo that's intended for distribution rather than packaging? Something where branches and paths won't change?

@pelwell
Copy link
Member

pelwell commented Dec 7, 2021

I wouldn't have a problem with putting both in the same repo, whether by replication or symbolic links (if that could work), i.e. retain the buster structure alongside the packaging info, but splitting the two is also OK.

Actually, creating a firmware repo under the raspberrypi Github organisation would solve another problem at the same time. We should discuss this offline.

@cons0l3 cons0l3 mentioned this issue Jan 21, 2022
Closed
jhofstee added a commit to victronenergy/meta-victronenergy that referenced this issue Jan 21, 2022
@jhofstee
linux-firmware-rpidistro: just sync it
d4ddf63 
There is more magic going one, just sync it with [1]
Completely untested!

victronenergy/venus#891
[1] agherzan/meta-raspberrypi@4c76dab
[2] RPi-Distro/firmware-nonfree#20
jhofstee added a commit to victronenergy/meta-victronenergy that referenced this issue Jan 21, 2022
@jhofstee
linux-firmware-rpidistro: just sync it
99ebffe 
There is more magic going one, just sync it with [1]
Completely untested!

victronenergy/venus#891
[1] agherzan/meta-raspberrypi@4c76dab
[2] RPi-Distro/firmware-nonfree#20
SimonSimCity added a commit to munit-solutions/meta-azure-device-update that referenced this issue Feb 18, 2022
@SimonSimCity
Added a note for dropped support of warrior and zeus
5d1fd2c 
Reason for dropping: RPi-Distro/firmware-nonfree#20
@colemickens
Copy link

I still get confused every time I try to do updates for NixOS. It would be great if there were clear answers for maintainers. We appear to have maybe just silently broken wifi for folks....

duvallee added a commit to duvallee/yocto_project_raspberrypi that referenced this issue May 3, 2022
@duvallee
----------------------------------------------------
fc3204d 
merge on 2022-05-03

last commit

commit 934064a01903b2ba9a82be93b3f0efdb4543a0e8 (HEAD -> dunfell, origin/dunfell)
Author: Pavel Zhukov <[email protected]>
Date:   Thu Nov 18 15:56:20 2021 +0100

    linux-firmware-rpidistro: Use buster branch instead of master

    Master branch has been renamed to buster.
    This change is dunfell-specific because master follows bullseye which
    diverted from ex-master quite a lot.

    Related: RPi-Distro/firmware-nonfree#20
    Signed-off-by: Pavel Zhukov <[email protected]>
@XECDesign
Copy link
Member

It would be great if there were clear answers for maintainers.

What's the question?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@rzr @korya @colemickens @XECDesign @pelwell