Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Add "minimal" firmware for AP+STA mode
Add a build of 7.45.241 with a reduced feature set that supports 19 clients in AP mode, while simultaneously allowing it to connect in STA mode. This is intended for applications such as Internet-in-a-Box that don't require advanced features. It is up to the user or distribution to rename the file or create a suitable symbolic link in order to use this cut-down firmware. Signed-off-by: Phil Elwell <[email protected]>
- Loading branch information
feeeda2There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it be possible to add a README that states specifically which features were removed? (I do recall you listed some of them in another issue discussion)
Having a record in a README file would be easier to find than digging through commit histories for others in the future.
feeeda2There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
README's are good things, in their absence yocto and alpine linux et. al. mailing lists are the best source of wifi driver info for the raspberry-pi... suboptimal to say the least...
feeeda2There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See 8b3067d.
feeeda2There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Which license is this blob is published under? Can it be redistributed unconditionally?
Edit: seeing this is already discussed raspberrypi/linux#4723 (comment)
feeeda2There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a Cypress file, published under Cypress's licence: https://github.com/RPi-Distro/firmware-nonfree/blob/buster/LICENCE.cypress
@XECDesign Can we add Cypress's licence file to the bullseye branch?
feeeda2There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I can know which files are under which license. Is everything in
/lib/firmware/brcm/using the broadcom license and everything under/lib/firmware/cypress/using the cypress license?feeeda2There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's more complex than that, since we also have some Synaptics firmware, although they have yet to come up with an acceptable licence file. Splitting the files into three directories with the associated licenses would be clearest.
feeeda2There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The packaging for all of this is on the non-trivial side, so adding multiple license files and changing directory structure would require further changes elsewhere for them to be picked up. Right now it scans for a single LICENSE file in debian/config/$package and uses that to generate the copyright file. The simplest way would be to add a single copyright file that outlines which files are covered by which license, and that would override the LICENSE file scan.
https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/
I still need to know which files are covered by which license. I can leave out the entries for synaptic files for now, if I know which those are.
feeeda2There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The firmware files (.bin and .clm_blob) in the
cypressdirectory are from Cypress, and the firmware files (.bin and .clm_blob) in thebrcmdirectry are from Synaptics, i.e. this repo no longer includes firmware from Broadcom. As it stands, all of the .txt files are in thebrcmdirectory, regardless of source, but I can't see that being a problem,feeeda2There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To summarise:
*43430*= Cypress*43436*= Synaptics*43455*= Cypress*43456*= Synapticsfeeeda2There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For extra fun, the copyright file actually needs to include the licensing information for all the files that end up in the binary package, not just the ones in this repo. I'll steal that information from the upstream archive and add the above.
Thanks!
feeeda2There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[ Scarily confusing proposed licence file deleted ]
feeeda2There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like Debian has had the same idea and have started simplifying how the licenses are distributed. That means the changes I intend to make will be easy to just copy into their new copyright file and we won't have to deal with the current auto-generated files.
feeeda2There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added
feeeda2There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
feeeda2There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The copyright file now includes a licence from Synaptics, covering the 43436 and 43456 devices.
feeeda2There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI that Debian link appears to no longer be valid due to the PR being merged
https://salsa.debian.org/kernel-team/firmware-nonfree/-/commit/f74917558a0bfd67f9e1395bba516dc98f3ad097 is the relevant merge commit which is probably a more persistent reference.
Thanks!
Edit: I am not personally concerned about it since I've seen plenty of projects that don't use the Signed-off-by concept and it is in my opinion unreasonable to force that process upon someone else's project, but others may be, and raspberrypi/linux#4723 (comment) is (I believe) a lawyer, the commit itself doesn't have the Signed-off-by field, and I suspect that unless you address the SFC lawyer's concerns, there will always be concerns from downstream projects that rely on them.