Let ck_splitk_decoder to use ck_tile headers only #58
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR solves a xformers building issue by removing the
ck_splitkv_decoder's
depending on the old_ck headers, makingck_splitkv_decoder
only uses the ck_tile headers.Without the fixing from this PR, building will fail while updating the ck_tiled submodule to latest ck develop due to the conflicts from the old_ck and ck_tile header files.
This is a quick fix, so performance is not considered. To achieve to the same performance, the
inner_product
inck_tile_attention_inner_product
should be improved.