Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let ck_splitk_decoder to use ck_tile headers only #58

Merged
merged 1 commit into from
Feb 13, 2025

Conversation

qianfengz
Copy link
Collaborator

This PR solves a xformers building issue by removing the ck_splitkv_decoder's depending on the old_ck headers, making ck_splitkv_decoder only uses the ck_tile headers.

Without the fixing from this PR, building will fail while updating the ck_tiled submodule to latest ck develop due to the conflicts from the old_ck and ck_tile header files.

This is a quick fix, so performance is not considered. To achieve to the same performance, the inner_product in ck_tile_attention_inner_product should be improved.

@qianfengz qianfengz merged commit 0144584 into develop Feb 13, 2025
0 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant