UCT/ROCM: fix memory type detection #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- fixed build io-demo on Ubuntu 20.04 - on some Ubuntu distro autotools don't follow libs dependency
UCP/CORE/GTEST: Fix not deallocating memory from ucp_mem_unmap if no rcache
UCT/IB/MLX5: Fix 2G aligned MR registration
BUILD/UBUNTU: fixed io-demo build
gilbertlee-amd
approved these changes
Apr 29, 2022
Some code blocks or function calls are considered slow-path, so the small overhead of compiled-in conditional profiling is worth the ease-of-use (no need to build UCX with profiling enabled). For example, memory registration, memory pool chunks allocations, etc.
…-profile-xx-always UCS/PROFILE: Add UCS_PROFILE_xx_ALWAYS macros, enabled in release mode
UCT/IB: Fix log_ack_req_freq field initialization
…evice-index-if UCT/SELF: Don't add device index if have only one device
Make sure operation attributes, especially UCP_OP_ATTR_FLAG_MULTI_SEND, would be passed to rendezvous protocol initialization and selection while processing RTS/RTR messages.
Fixes openucx#8186 Signed-off-by: Pavel Shamis (Pasha) <[email protected]>
GTEST: Silence use-after-free Fedora 36 GCC error
…ated-functions-to-ucp UCP/API: Move deprecated functions to ucp_compat.h
…tr-mask-to UCP/PROTO: Add op_attr_mask to rendezvous protocol selection
fix the approach used to identify ROCm memory type. ROCm memory type is as of right now of type HSA_EXT_POINTER_TYPE_HSA with the owner agent being a GPU.
edgargabriel
force-pushed
the
topic/memtype_detection_fix
branch
from
4df031b to
6efdbb4
Compare
edgargabriel
pushed a commit
that referenced
this pull request
May 2, 2023
AZP/RELEASE: Add ARM release - Part #2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
fix the approach used to identify ROCm memory type.
Why ?
The current algorithm in the code lead to problems with the rocm/ipc component, since memory allocations not capable of providing an ipc handle have been trying to use this component.
How ?
ROCm memory type is defined as being of type HSA_EXT_POINTER_TYPE_HSA with the owner agent being a GPU.