-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Streamk v0.3 #660
Streamk v0.3 #660
Conversation
* Add grid model * Add comments to explain constants
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, my biggest comment here is I wonder if there's a way to merge streamk_kernel and streamk_kernel_atomic with some constexpr, so it uses the same code but uses atomics for the partials instead. That seems to be the fundamental change between the two but a bunch of redundant code is being used.
the reason to put in atomics kernel here is for Ilia to test some accuracy issue of atomic_add, I would like to keep it separate for now just because we don't want to complicate the opt for our remainder part. We have next big task for reducing vgpr spills for the remainder. |
Looks good, thanks! |
streamk gemm script v0.3