Crop - Tensor implementation on hip and host #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AryanSalmanpour
requested changes
Dec 7, 2021
src/include/hip/rpp_hip_common.hpp
Outdated
| #include <hip/hip_runtime_api.h> | ||
| #include <hip/hip_runtime.h> | ||
| #include <hip/hip_ext.h> | ||
| #include <hip/hip_fp16.h> | ||
| #include <hip/hcc_detail/hip_vector_types.h> |
There was a problem hiding this comment.
please don't include files from the hcc_detail folder from the hip. including from the hip/hip_fp16 header should give you access to all the HIP's fp16 functionalities.
There was a problem hiding this comment.
Reverted back the headers without hcc_detail
AryanSalmanpour
requested changes
Dec 8, 2021
AryanSalmanpour
approved these changes
Dec 9, 2021
rrawther
reviewed
Dec 9, 2021
| inline RppStatus rpp_load48_u8pkd3_to_u8pln3(Rpp8u *srcPtr, __m128i *px) | ||
| { | ||
| __m128i pxSrc[8]; | ||
| __m128i pxMask = _mm_setr_epi8(0, 3, 6, 9, 1, 4, 7, 10, 2, 5, 8, 11, 12, 13, 14, 15); |
There was a problem hiding this comment.
I think pxMask and pxMaskRGB is repeatedly used in many functions. Consider defining it as global constant
rrawther
reviewed
Dec 10, 2021
| } | ||
|
|
||
| // Uncomment to run test case with an ltrbROI override | ||
| /*for (i = 0; i < images; i++) |
There was a problem hiding this comment.
It is better to pass parameters through arguments instead of commenting and uncommenting code.
rrawther
reviewed
Dec 10, 2021
|
@asalmanp @rrawther @r-abishek This PR passes all unit tests. |
kiritigowda
approved these changes
Dec 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@rrawther @asalmanp This PR adds the tensor implementation for crop on hip and host, and the corresponding unit tests and performance tests.