Build fix for ROCm 6.0.0 gfx942 #295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kiritigowda
approved these changes
Jan 31, 2024
Turn Advance build by default
rrawther
reviewed
Jan 31, 2024
| atomicInc(&tmp_histogram[pixelR], 1); | ||
| atomicInc(&tmp_histogram[pixelG], 1); | ||
| atomicInc(&tmp_histogram[pixelB], 1); | ||
| atomicAdd(&tmp_histogram[pixelR], 1); |
There was a problem hiding this comment.
Is atomicAdd good option. I thought we can't use any atomics
There was a problem hiding this comment.
@rrawther Ubuntu build seems to pass with atomicAdd. Ideally, both should work as they did on openCL/cuda/hip, but for some reason only atomicInc() fails on Rocm6.0.0 HIP
Note update for -D option
kiritigowda
approved these changes
Jan 31, 2024
kiritigowda
added a commit
that referenced
this pull request
Jan 31, 2024
* modified histogram hip kernel to use atomicAdd instead of atomicInc * Update CMakeLists.txt Turn Advance build by default * Update CMakeLists.txt Note update for -D option --------- Co-authored-by: sampath1117 <[email protected]> Co-authored-by: Kiriti Gowda <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@kiritigowda Fix for #291