Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENABLE ASAN PACKAGING with component split dev, runtime and asan #235

Merged
merged 5 commits into from
Oct 27, 2023
Merged

ENABLE ASAN PACKAGING with component split dev, runtime and asan #235

merged 5 commits into from
Oct 27, 2023

Conversation

arvindcheru
Copy link
Contributor

Proposed Changes:

  • Enable ASAN Packaging (component based split for dev, runtime and asan)
  • Add LICENSE file to RPP package

@kiritigowda kiritigowda changed the base branch from master to develop October 20, 2023 17:11
@kiritigowda kiritigowda self-requested a review October 20, 2023 17:12
@kiritigowda kiritigowda added the enhancement New feature or request label Oct 20, 2023
@kiritigowda
Copy link
Collaborator

@arvindcheru failing CI - http://math-ci.amd.com/blue/organizations/jenkins/main%2FShort-GPUOpen%2Frpp/detail/PR-235/1/pipeline/698

@kiritigowda kiritigowda changed the base branch from develop to master October 23, 2023 04:59
@kiritigowda kiritigowda changed the base branch from master to develop October 23, 2023 06:18
@kiritigowda
Copy link
Collaborator

@arvindcheru - could you add updates to changelog - Please sync with develop branch.

@arvindcheru arvindcheru reopened this Oct 24, 2023
@arvindcheru
Copy link
Contributor Author

@arvindcheru - could you add updates to changelog - Please sync with develop branch.

Updated Changelog Pls review

@kiritigowda
Copy link
Collaborator

@arvindcheru - merge pending CI - failing - http://math-ci.amd.com/blue/organizations/jenkins/main%2FShort-GPUOpen%2Frpp/detail/PR-235/1/pipeline
Can you please take a look?

@kiritigowda
Copy link
Collaborator

@arvindcheru - CI Pass - http://math-ci.amd.com/blue/organizations/jenkins/main%2FShort-GPUOpen%2Frpp/detail/PR-235/4/pipeline/924

@kiritigowda kiritigowda merged commit fc203eb into ROCm:develop Oct 27, 2023
kiritigowda added a commit that referenced this pull request Oct 31, 2023
@arvindcheru @kiritigowda
Packaging - ENABLE ASAN PACKAGING with component split dev, runtime a…
808c92c 
…nd asan (#235)

* ENABLE ASAN packaging RPP

* Review Comments - Updated Changelog

* Review Comments - Updated Version Handling

* Update common.groovy

* Update common.groovy

---------

Co-authored-by: Kiriti Gowda <[email protected]>
@pramenku pramenku mentioned this pull request Nov 2, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kiritigowda kiritigowda kiritigowda left review comments

@saadrahim saadrahim Awaiting requested review from saadrahim

Assignees

@paveltc paveltc

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@arvindcheru @kiritigowda @paveltc