merge release code into development #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Header file path updated to amd-dbgapi/amd-dbgapi.h based on dbgapi changes Depends-On: I74367e6961b8658511bd1225e1725182308f0a01 Depends-On: I446c3edd0a20eafc47aaac084e6ff9216870400c Change-Id: I472b5194127cacd9e31f2d9ca4f8ca066d7153d3
When printing all wavefronts is requested, the debug agent must stop running waves before inspecting their state. The stop_all_wavefronts function iterates all wavefronts, and stops the wavefronts that are still running. stop_all_wavefronts was failing to detect already stopped wavefronts. Added a check before sending the stop request as it is illegal to send a stop request to an already stopped wavefront. Also noticed that the stopped events were not reported as processed, and resuming wavefronts with stop events was returning an error. A wave is only trully stopped when the stop event is processed. Added amd_dbgapi_event_processed to both event loops. Change-Id: I0eb09d61253e1682488eb6b3c389854f195fdab1
GNUInstallDirs sets CMAKE_INSTALL_DOCDIR using the project name (DATAROOTDIR/doc/PROJECT_NAME). Since we want to use rocm-debug-agent for directory names, change the project name to rocm-debug-agent. Change-Id: I78427fc299b81baadc92ad1a5e77ab9c7052562b
Use GNUInstallDirs variables to determine the location of BINDIR, LIBDIR, INCLUDEDIR, DOCDIR, LIBEXECDIR and DATADIR. Change-Id: I5e9a78d094a15d5c96465df48e8fc12237991aaf
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
merge release code into development