Fix issue#66 #75
Open
Fix issue#66 #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When building the json data flow, from_us_list has (timestamp, stream_id, thread_id). stream_id used to be interpreted as from_tid and tid as to_tid. But that's not correct. stream_id is always a destination and tid is the initiator (source). Change-Id: I2f5bb86a387b4003b17271c90bdf9de4b59a79bf
Merge gfx90a support from the 'amd-npi' branch. Change-Id: I9b51711ed4a1d2f1ed42ba9b83cb12136be228b8 (cherry picked from commit 4df3e0b)
Marker events inside hcc_ops_trace.txt are from barriers so they are not meant to be stored in ops_patch_data map. Added support for hipMemset events which are a kind of memory copy. Change-Id: I213fe959bcd35ff0371613ba5bffd95bc53e06b5 (cherry picked from commit caa5f32)
…ster Change-Id: I65e98f8fe3186d67fecee47634715cc9343566e6
Signed-off-by: Icarus Sparry <[email protected]> Change-Id: Icb935e9230888fd005d9ca3617e28f6173173cc8
…ster Change-Id: Idb93c5ea1cfeebdda286a9438de4211688c7869b
…ster Change-Id: I09ba8c7da383d149600dd94c1c12b7632ff20896
…ster Change-Id: I44f7c90e529729745962be0ac5b8bb644af4ee55
…ster Change-Id: I959acf1c685a8f1d234c03f9a9bfa0ea4cf539d9
…ster Change-Id: Ifdb1f9558bdd16f316b1f38abbb22ef83bc45146
…ler metrics Changed derived metrics to double from int64. Fixed standalone test due to int64 to float change Fixed intercept test due to int64 to float change. Change-Id: I49631c187406ae9dd94a869b3bb13772012e8cdf (cherry picked from commit f9017cb)
Fixed exception thrown when ROCP_HSA_INTERCEPT not set or set to 0; Fixed ROCM hsa_init() failed with error 4096 when trying to read hardware performance counters; Fixed LD_LIBRARY_PATH to include necessary library; Change-Id: Idcb7ff807a79f4267374c34041d3bca33d85f532
…ler metrics Changed var_pattern in tblextr.py to include pattern like "name[0]" Change-Id: Ibe1c512595cfbdcaca8fa5bddceb3f6a570caf43 (cherry picked from commit ff43ca1)
Change-Id: I6cea078e5b64a68d7bd269dc3aab976a7ab7b5c7
Change-Id: Ib7d33a4b7f3306b7195ff89c28b021fb1fa6bc88 (cherry picked from commit 2519d00)
user provided empty feature set to track. Fixed this behaviour
It's impossible to guarantee order of the InitHsaApiTable and EnableExecutableTracking calls. Added explicit check for infinite recursion in EnableExecutableTracking call.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added explicit check for infinite recursion in EnableExecutableTracking function. It's impossible to guarantee any order of EnableExecutableTracking and InitHsaApiTable. Removing null check for hsa_api_.hsa_init will add dependency from number and order of InitHsaApiTable calls.