Skip to content

Commit

Permalink
SWDEV-494273: Temporary remove SPI selection
Browse files Browse the repository at this point in the history
This reverts commit e5e2c60.

Reason for revert: Requires priv_cp_queues=1

Change-Id: Ia6c78ac25b88d7ef4703654075d54e672a6e320c
(cherry picked from commit a6328a1)
  • Loading branch information
ApoKalipse-V committed Oct 25, 2024
1 parent e5e2c60 commit ec0e166
Show file tree
Hide file tree
Showing 3 changed files with 1 addition and 27 deletions.
8 changes: 1 addition & 7 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -340,10 +340,4 @@ Example for file plugin output:
### Added

- JSON output plugin for rocprofv2, the JSON file matches Google Trace Format, so it should be easily loaded to perfetto, chrome tracing or speedscope. For Speedscope, `--disable-json-data-flows` option will be needed as speedscope doesn't work with data flows.
- Added `--no-serialization` flag to disable kernel serialization when rocprofv2 is in counter-collection mode. This change was added to allow rocprofv2 to avoid deadlock when profiling certain programs in counter-collection mode.

## ROCprofiler for rocm 6.3

### Added

- SPI Pipe Selection
- Added `--no-serialization` flag to disable kernel serialization when rocprofv2 is in counter-collection mode. This change was added to allow rocprofv2 to avoid deadlock when profiling certain programs in counter-collection mode.
10 changes: 0 additions & 10 deletions src/core/counters/metrics/basic_counters.xml
Original file line number Diff line number Diff line change
Expand Up @@ -363,11 +363,6 @@
<metric name="TCC_ALL_TC_OP_INV_EVICT" block=TCC event=80 descr="Number of evictions due to all TC_OP invalidate requests."></metric>
<metric name="TCC_EA_RDREQ_DRAM" block=TCC event=102 descr="Number of TCC/EA read requests (either 32-byte or 64-byte) destined for DRAM (MC)."></metric>
<metric name="TCC_EA_WRREQ_DRAM" block=TCC event=103 descr="Number of TCC/EA write requests (either 32-byte of 64-byte) destined for DRAM (MC)."></metric>

<metric name="SPI_PIPE_0" block=SPI event=16777216 descr="Dummy Counter. Used to select SPI Pipe 0"></metric>
<metric name="SPI_PIPE_1" block=SPI event=16777217 descr="Dummy Counter. Used to select SPI Pipe 1"></metric>
<metric name="SPI_PIPE_2" block=SPI event=16777218 descr="Dummy Counter. Used to select SPI Pipe 2"></metric>
<metric name="SPI_PIPE_3" block=SPI event=16777219 descr="Dummy Counter. Used to select SPI Pipe 3"></metric>
</gfx90a>

<gfx940>
Expand Down Expand Up @@ -630,11 +625,6 @@
<metric name="TCC_PROBE_EVICT" block=TCC event=81 descr="Number of evictions/invalidations due to probes. Not windowable."></metric>
<metric name="TCC_EA0_RDREQ_DRAM" block=TCC event=102 descr="Number of TCC/EA read requests (either 32-byte or 64-byte) destined for DRAM (MC)."></metric>
<metric name="TCC_EA0_WRREQ_DRAM" block=TCC event=103 descr="Number of TCC/EA write requests (either 32-byte of 64-byte) destined for DRAM (MC)."></metric>

<metric name="SPI_PIPE_0" block=SPI event=16777216 descr="Dummy Counter. Used to select SPI Pipe 0"></metric>
<metric name="SPI_PIPE_1" block=SPI event=16777217 descr="Dummy Counter. Used to select SPI Pipe 1"></metric>
<metric name="SPI_PIPE_2" block=SPI event=16777218 descr="Dummy Counter. Used to select SPI Pipe 2"></metric>
<metric name="SPI_PIPE_3" block=SPI event=16777219 descr="Dummy Counter. Used to select SPI Pipe 3"></metric>
</gfx940>

<gfx941 base="gfx940"></gfx941>
Expand Down
10 changes: 0 additions & 10 deletions test/tool/gfx_metrics.xml
Original file line number Diff line number Diff line change
Expand Up @@ -364,11 +364,6 @@
<metric name="TCC_ALL_TC_OP_INV_EVICT" block=TCC event=80 descr="Number of evictions due to all TC_OP invalidate requests."></metric>
<metric name="TCC_EA_RDREQ_DRAM" block=TCC event=102 descr="Number of TCC/EA read requests (either 32-byte or 64-byte) destined for DRAM (MC)."></metric>
<metric name="TCC_EA_WRREQ_DRAM" block=TCC event=103 descr="Number of TCC/EA write requests (either 32-byte of 64-byte) destined for DRAM (MC)."></metric>

<metric name="SPI_PIPE_0" block=SPI event=16777216 descr="Dummy Counter. Used to select SPI Pipe 0"></metric>
<metric name="SPI_PIPE_1" block=SPI event=16777217 descr="Dummy Counter. Used to select SPI Pipe 1"></metric>
<metric name="SPI_PIPE_2" block=SPI event=16777218 descr="Dummy Counter. Used to select SPI Pipe 2"></metric>
<metric name="SPI_PIPE_3" block=SPI event=16777219 descr="Dummy Counter. Used to select SPI Pipe 3"></metric>
</gfx90a>

<gfx940>
Expand Down Expand Up @@ -629,11 +624,6 @@
<metric name="TCC_PROBE_EVICT" block=TCC event=81 descr="Number of evictions/invalidations due to probes. Not windowable."></metric>
<metric name="TCC_EA0_RDREQ_DRAM" block=TCC event=102 descr="Number of TCC/EA read requests (either 32-byte or 64-byte) destined for DRAM (MC)."></metric>
<metric name="TCC_EA0_WRREQ_DRAM" block=TCC event=103 descr="Number of TCC/EA write requests (either 32-byte of 64-byte) destined for DRAM (MC)."></metric>

<metric name="SPI_PIPE_0" block=SPI event=16777216 descr="Dummy Counter. Used to select SPI Pipe 0"></metric>
<metric name="SPI_PIPE_1" block=SPI event=16777217 descr="Dummy Counter. Used to select SPI Pipe 1"></metric>
<metric name="SPI_PIPE_2" block=SPI event=16777218 descr="Dummy Counter. Used to select SPI Pipe 2"></metric>
<metric name="SPI_PIPE_3" block=SPI event=16777219 descr="Dummy Counter. Used to select SPI Pipe 3"></metric>
</gfx940>

<gfx941 base="gfx940"></gfx941>
Expand Down

0 comments on commit ec0e166

Please sign in to comment.