Fix not enabling fp8 WMMA on Navi4 by default #1677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
getDefaultFeatures() in the architecture database hadn't been told that sometimes there's a fp8 WMMA, so it wasn't sending those operations down that path. This commit fixes the issue and tests that enablement.
krzysz00
changed the title
stefankoncarevic
approved these changes
Oct 9, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1677 +/- ##
===========================================
+ Coverage 78.07% 78.24% +0.17%
===========================================
Files 98 98
Lines 26501 26498 -3
Branches 3809 3809
===========================================
+ Hits 20691 20734 +43
+ Misses 4308 4264 -44
+ Partials 1502 1500 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
dhernandez0
pushed a commit
that referenced
this pull request
Oct 29, 2024
Fix not enabling WMMA on Navi4 by default getDefaultFeatures() in the architecture database hadn't been told that sometimes there's a fp8 WMMA, so it wasn't sending those operations down that path. This commit fixes the issue and tests that enablement.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
getDefaultFeatures() in the architecture database hadn't been told that sometimes there's a fp8 WMMA, so it wasn't sending those operations down that path.
This commit fixes the issue and tests that enablement.