Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for ROI decode on MI300 #53

Merged
merged 5 commits into from
Aug 22, 2024

Conversation

AryanSalmanpour
Copy link
Member

This PR implements the ROI decoding using the HW JPEG decoder. If the hardware supports this feature, we fill the requested crop rectangle to the designated picture parameter buffer and pass it to the VA-API.

@AryanSalmanpour AryanSalmanpour merged commit 7b321a8 into ROCm:develop Aug 22, 2024
7 checks passed
@AryanSalmanpour AryanSalmanpour deleted the as/roi_decode_mi300 branch August 23, 2024 13:46
vamovsik pushed a commit that referenced this pull request Nov 19, 2024
* Update Samples (#52)

* Add support for ROI decode on MI300 (#53)

* Add support for ROI decode on MI300

* Add ROI decode support for batched decoding

* clean up

* clean up

* Fix a typo and update sample's readme

* Increase the output image size for rgb and rgb_planar (#54)

* Increase the output image size for rgb and rgb_planar to avoi

* code clean up

* rename yuv to yuv_planar for the output format (#55)

* update docs (#56)

* update docs

* remove extra line

* clean up

* Optimize the memory pool allocation bso that its size doesn't exceed the max_pool_size_ (#58)

* update clang path per packaging (#59)

* Fix few typos in the header file - no functional changes (#61)

* Add code owners for the rocJPEG (#62)

* Add code owners for the rocJPEG

* code clean up

* Exclude YUV 4:4:0 for RGB format conversion in VCN on MI300, as it is not supported. Instead, use HIP kernels. (#63)

* Update the libva requirement (#64)

* Update the libva requirement

* clean up READNE file

* Prepare documentation (#57)

* Updated the readme file to point to the official documentation

* first commit of new documentation structure

* split up and reconfigured Using rocJpeg

* Updated the readme file to point to the official documentation

* first commit of new documentation structure

* split up and reconfigured Using rocJpeg

* fixed missing space

* All changes asked for in the PR except the Destroy Handles part.

* separated creating and destroying handles; added a destroying handles section; added links to hipmalloc() and hipfree()

* removed the installation and build sections so that it doesn't conflict/go out of sync with the official doc

* putting readme back the way it was, minus documentation section

* changed some wording around hipFree()

* Find the minimum supported libva version 1.16 when building rocJPEG (#65)

* Fix a typo in README/Docs (#66)

* use a single context for decoding (#68)

* increase the mem_alignment size used for output image rgb memory allocation (#70)

---------

Co-authored-by: Lakshmi Kumar <[email protected]>
Co-authored-by: spolifroni-amd <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants