changed the CMake option from AMDGPU_TARGETS to GPU_TARGETS #1435
+24
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akolliasAMD
requested review from
wenkaidu,
gilbertlee-amd,
edgargabriel,
PedramAlizadeh,
nusislam,
nileshnegi,
KawtharShafie,
AtlantaPepsi,
mberenjk,
corey-derochie-amd,
mustafabar,
thananon and
haripriya-amd
as code owners
|
might need to change ./install.sh and README.md for the |
nileshnegi
reviewed
Nov 26, 2024
| if [[ ! -z "${build_amdgpu_targets}" ]]; then | ||
| cmake_common_options="${cmake_common_options} -DAMDGPU_TARGETS=${build_amdgpu_targets}" | ||
| if [[ ! -z "${build_gpu_targets}" ]]; then | ||
| cmake_common_options="${cmake_common_options} -DAMDGPU_TARGETS=${build_gpu_targets}" |
|
@akolliasAMD: This is going to collide with #1427. I don't think all of your changes are applicable to 6.3, so we might want to get my changes in first so I can backport to 6.3.0 without picking up these changes. I'm just waiting for a manager approval from docs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Changed cmake to accept GPU_TARGETS as the option for target different gpu targets
Work item: _"Internal"
Why were the changes made?
Rocm general change
Approval Checklist
Do not approve until these items are satisfied.