Add set_false_math to false to solve accuracy issue for gelu test. #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add ORT_MIGRAPHX_SET_FAST_MATH env option and api hooks Allow users to set the fast math option for MIGraphX compilation for quantized data types (fp16) This allows us to toggle whether we can use faster math with the tradeoff of accuracy. Revert "fixup! Add ORT_MIGRAPHX_SET_FAST_MATH env option and api hooks" This reverts commit d369a15. Revert "Add ORT_MIGRAPHX_SET_FAST_MATH env option and api hooks" This reverts commit 3819961.
Closed
5 tasks
|
Not needed. Hoping to get : microsoft#20520 upstream or will cherry-pick patch upcoming branches if needed if this doesn't get in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Patching in fast match disabled in the MIGraphX Compile stage in the MIGraphX EP
Description
Allow the MIGraphX API to compile the program given to the EP to turn off fast math by default.
Motivation and Context
Fixes accuracy issue we're seeing with GELU parity tests. Without fast math disabled GELU will use a faster but less numerically stable version which trades speed for accuracy.