Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link to the "Known Issue" note next to references of Perfetto. #393

Merged
merged 5 commits into from
Sep 26, 2024

Conversation

dgaliffiAMD
Copy link
Collaborator

No description provided.

@dgaliffiAMD dgaliffiAMD requested a review from a team as a code owner September 25, 2024 16:27
docs/how-to/understanding-omnitrace-output.rst Outdated Show resolved Hide resolved
docs/what-is-omnitrace.rst Outdated Show resolved Hide resolved
docs/install/install.rst Outdated Show resolved Hide resolved
@dgaliffiAMD
Copy link
Collaborator Author

Thanks, @peterjunpark . I've merged your changes and updated "understanding-omnitrace-output" as well.

Copy link

@gsitaram gsitaram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dgaliffiAMD , looks good although I don't know how to check how this would be rendered in the HTML document. I trust your experience on that. Thank you for fixing this.

@dgaliffiAMD dgaliffiAMD merged commit 17ff1dc into ROCm:main Sep 26, 2024
5 checks passed
@dgaliffiAMD dgaliffiAMD deleted the update-perfetto-docs branch September 26, 2024 02:34
@peterjunpark
Copy link
Contributor

@dgaliffiAMD , looks good although I don't know how to check how this would be rendered in the HTML document. I trust your experience on that. Thank you for fixing this.

image
This link will show you a demo webpage @gsitaram

@gsitaram
Copy link

This is very good to learn, @peterjunpark. Thank you!

dgaliffiAMD added a commit that referenced this pull request Sep 26, 2024
* And provide workaround link to Perfetto v46.0

Co-authored-by: Peter Park <[email protected]>
dgaliffiAMD added a commit that referenced this pull request Sep 26, 2024
* And provide workaround link to Perfetto v46.0

Co-authored-by: Peter Park <[email protected]>
peterjunpark added a commit to peterjunpark/omnitrace that referenced this pull request Sep 26, 2024
* And provide workaround link to Perfetto v46.0

Co-authored-by: Peter Park <[email protected]>
peterjunpark added a commit to peterjunpark/omnitrace that referenced this pull request Sep 26, 2024
* And provide workaround link to Perfetto v46.0

Co-authored-by: Peter Park <[email protected]>
peterjunpark added a commit that referenced this pull request Sep 26, 2024
* And provide workaround link to Perfetto v46.0

Co-authored-by: Peter Park <[email protected]>
peterjunpark added a commit to peterjunpark/omnitrace that referenced this pull request Sep 26, 2024
* And provide workaround link to Perfetto v46.0

Co-authored-by: Peter Park <[email protected]>
peterjunpark added a commit to peterjunpark/omnitrace that referenced this pull request Sep 26, 2024
* And provide workaround link to Perfetto v46.0

Co-authored-by: Peter Park <[email protected]>
peterjunpark added a commit that referenced this pull request Sep 26, 2024
* And provide workaround link to Perfetto v46.0

Co-authored-by: Peter Park <[email protected]>
dgaliffiAMD added a commit that referenced this pull request Sep 27, 2024
* And provide workaround link to Perfetto v46.0

Co-authored-by: Peter Park <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants