Add option to skip barrier marker events in traces #320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrmadsen
requested changes
Dec 14, 2023
|
@jrmadsen Done, thank you. |
|
@jrmadsen Reran clang-format, hopefully it all passes now. |
We’ve currently got a problem with the MPI test cases when they run on the free GitHub runners so it’s unlikely everything will pass. We are currently evaluating how we want to proceed |
Co-authored-by: Jonathan R. Madsen <[email protected]>
jrmadsen
force-pushed
the
discard-barriers
branch
from
4a09079 to
668bc0b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When inspecting traces with multiple queues, barrier events can be overwhelming on the profile. This PR creates a config entry to not include those in the output file. The configuration is disabled by default, so it should not affect the existing behavior.