Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix to 6.3.1 #301

Open
wants to merge 2 commits into
base: release/rocm-rel-6.3
Choose a base branch
from
Open

Fix to 6.3.1 #301

wants to merge 2 commits into from
+27 −24

Conversation

CongMa13
Copy link
Collaborator

  • CK fixed an issue that prevented it from supporting unit tests with beta is not equal to 0. Add these unit tests back.
  • Update changelog for rocm release 6.3

@CongMa13
Add unit tests back
17970da 
CK fixed an issue that prevented it from supporting unit tests with
beta is not equal to 0.

Add these unit tests back.
amd-jnovotny
amd-jnovotny approved these changes Nov 26, 2024
View reviewed changes
Copy link

@amd-jnovotny amd-jnovotny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docs changes are okay. Is there anything for the 6.3.1 changelog or just updates to the 6.3.0 log.

@cgmillette
Copy link
Collaborator

Docs changes are okay. Is there anything for the 6.3.1 changelog or just updates to the 6.3.0 log.

The fix is already upstream in CK for 6.3.0. Just re-enabling some tests. We can just keep updates to the 6.3.0 log.

cgmillette
cgmillette approved these changes Nov 26, 2024
View reviewed changes
Copy link
Collaborator

@cgmillette cgmillette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amd-jnovotny amd-jnovotny amd-jnovotny approved these changes

@cgmillette cgmillette cgmillette approved these changes

@bragadeesh bragadeesh Awaiting requested review from bragadeesh bragadeesh is a code owner

@dlangbe dlangbe Awaiting requested review from dlangbe dlangbe is a code owner

@afanfa afanfa Awaiting requested review from afanfa afanfa is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@CongMa13 @cgmillette @amd-jnovotny @spolifroni-amd