Permutation selection #297
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The template parameters passed to CK permutation class cannot be extracted from them. Need to save these infomation in class DeviceElementwiseParams so that it is possible to query a specific CK permutation class by these template parameters.
CongMa13
commented
Nov 25, 2024
| return op_ptrs; | ||
| std::unordered_map<hiptensor::Uid, std::unique_ptr<DeviceOp>> opPtrs; | ||
| // clang-format off | ||
| addInstance<256, 64, 64, 4, 4, ck::Sequence<0, 1>, ck::Sequence<4>, ck::Sequence<4>>(opPtrs); |
There was a problem hiding this comment.
Will add the instances with best performance in another PR when the performance test is done.
CongMa13
force-pushed
the
permutation_selection
branch
from
28702c2
to
811086e
Compare
CongMa13
requested review from
cgmillette,
bragadeesh,
dlangbe and
afanfa
as code owners
- The registry contains only one hash table. The key is the hash code of all template parameters of permutation instance classes. - Removed Query class.
CongMa13
force-pushed
the
permutation_selection
branch
from
811086e
to
3eeab9e
Compare
cgmillette
reviewed
Nov 26, 2024
| @@ -26,11 +26,7 @@ | |||
|
|
|||
| set(CK_PERMUTATION_INSTANCE_SOURCES | |||
| ${CMAKE_CURRENT_SOURCE_DIR}/hiptensor_permutation_scale_instances.hpp | |||
There was a problem hiding this comment.
Not sure why there are hpp files in source list?
cgmillette
reviewed
Nov 27, 2024
| m1PerThread, | ||
| threadClusterArrangeOrder.first, | ||
| threadClusterArrangeOrder.second, | ||
| scalarPerVectorSeq, |
There was a problem hiding this comment.
Do both in and out have to be the same? Or is it interesting to have a combinatorial set for both in and out?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the permutation instance selection.
The work flow