Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Permutation selection #297

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

CongMa13
Copy link
Collaborator

Added the permutation instance selection.

  • Removed duplicated code in device folder.
  • Removed Query which is not used in solution_registry
  • Added selection of instances based on lengths of input tensor
    • selection function is hard code now.

The work flow

image

The template parameters passed to CK permutation class cannot be extracted from them.

Need to save these infomation in class DeviceElementwiseParams so that it is possible to query
a specific CK permutation class by these template parameters.
return op_ptrs;
std::unordered_map<hiptensor::Uid, std::unique_ptr<DeviceOp>> opPtrs;
// clang-format off
addInstance<256, 64, 64, 4, 4, ck::Sequence<0, 1>, ck::Sequence<4>, ck::Sequence<4>>(opPtrs);
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will add the instances with best performance in another PR when the performance test is done.

- The registry contains only one hash table. The key is the hash code
  of all template parameters of permutation instance classes.
- Removed Query class.
@@ -26,11 +26,7 @@

set(CK_PERMUTATION_INSTANCE_SOURCES
${CMAKE_CURRENT_SOURCE_DIR}/hiptensor_permutation_scale_instances.hpp
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why there are hpp files in source list?

m1PerThread,
threadClusterArrangeOrder.first,
threadClusterArrangeOrder.second,
scalarPerVectorSeq,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do both in and out have to be the same? Or is it interesting to have a combinatorial set for both in and out?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants