Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor hipBLAS documentation (#950) #962

Open
wants to merge 1 commit into
base: release-staging/rocm-rel-6.4
Choose a base branch
from

Conversation

amcamd
Copy link
Contributor

@amcamd amcamd commented Feb 13, 2025

Need to make sure this only contains 6.4 content

  • Initial draft. Requires more work before push

  • Refactor remaining files and additional edits

  • Apply suggestions from team review

  • Fix errors in API reference

  • Incorporate comments from review

  • A few additional edits

* Initial draft. Requires more work before push

* Refactor remaining files and additional edits

* Apply suggestions from team review

* Fix errors in API reference

* Incorporate comments from review

* A few additional edits
Copy link
Contributor

@amd-jnovotny amd-jnovotny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did some spot checks, and it looks all right. I think the docs folder is the same between 6.4 and develop with the exception of dependabot/rocm-docs-core changes, which shouldn't affect this PR.

Copy link
Contributor

@TorreZuk TorreZuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it looks to be all there. Maybe get Daine to approve as well. Has the deprecation always been in oldest to newest order? I think newest to oldest would be an improvement.

@amd-jnovotny
Copy link
Contributor

@TorreZuk : Yes, hipBLAS deprecations were listed oldest to newest. I just fixed some formatting problems and typos. But your idea is a good one. I could potentially change this with a new PR if you'd like. I have to handle some higher priority work right now but could circle back to this.

@TorreZuk
Copy link
Contributor

@TorreZuk : Yes, hipBLAS deprecations were listed oldest to newest. I just fixed some formatting problems and typos. But your idea is a good one. I could potentially change this with a new PR if you'd like. I have to handle some higher priority work right now but could circle back to this.

Fine to reorder only into develop for next release. Is this consistent across libraries?

@amd-jnovotny
Copy link
Contributor

@TorreZuk As it turns out, the order for rocBLAS was mixed up and in no consistent order, so I put that one into newest to oldest. So definitely it would be good to bring hipBLAS into line with that.

Not every repo has a deprecation listing and some just have it at the bottom of their API docs. I'll do a survey to see if there's a pattern.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants