EXSWHTEC-106 - Reimplement tests for hipOccupancyMaxActiveBlocksPerMultiprocessor and hipOccupancyMaxPotentialBlockSize APIs #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
nives-vukovic
commented
Dec 9, 2022
nives-vukovic
commented
- Add helper file occupancy_common.hh with parameterized templates
- Expand all positive and negative tests to use the templates
Change-Id: I66f0c09e9c7405ec7430b1883e0e89542fdb87a0
Change-Id: I212b82b1b3a78a368b85ea64e338371a34b405f9
Change-Id: Ib455f72b5be77e1a81137d15c07ea41161b16a3e
Change-Id: Ief96e274f4143e80ceb3e40f04d38ae217777583
Change-Id: I9c03cde09b42c8e3726153c2a177359efc8d6d29
…ltiprocessor and hipOccupancyMaxPotentialBlockSize APIs - Add helper file occupancy_common.hh with parameterized templates - Expand all positive and negative tests to use the templates
chrispaquot
reviewed
Mar 9, 2023
| }, | ||
| blockSize); | ||
|
|
||
| #if HT_NVIDIA // EXSWHTEC-219 |
There was a problem hiding this comment.
remove this and use json file. I talked to @mangupta and we just want to avoid the whole test case.
There was a problem hiding this comment.
@chrispaquot It has been removed and test has been disabled using json files.
chrispaquot
approved these changes
Apr 4, 2023
|
@nives-vukovic |
|
@rorake Conflicts are resolved. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.