[TESTS][FP16][WORKAROUND] Fix test_conv_igemm_dynamic_xdlops* and test_regression_half_vega. W/A for #995 and #996 #991
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix: Enable test_conv_igemm_dynamic_xdlops_fwd for HALF type - Fix: Enable test_conv_igemm_dynamic_xdlops_wrw for HALF type - Fix: Properly enable test_regression_half_vega (it did nothing before) - Refactoring: Remove some useless if's.
atamazov
changed the title
4 tasks
This reverts commit 0c845ef.
# RESOLVED Conflicts: # test/CMakeLists.txt
atamazov
changed the title
This comment has been minimized.
This comment has been minimized.
|
@qianfengz @shaojiewang @carlushuang @shurale-nkn Please approve. This blocks #958 |
shaojiewang
reviewed
Jun 22, 2021
| # WORKAROUND_ISSUE_996 | ||
| # COMMAND ${DYNAMIC_IMPLICITGEMM_WRW_ENVS_XDLOPS} $<TARGET_FILE:test_conv2d> ${MIOPEN_TEST_FLOAT_ARG} --verbose --input 400 256 1 1 --weights 1024 256 1 1 --pads_strides_dilations 0 0 1 1 1 1 --disable-forward --disable-backward-data | ||
| # WORKAROUND_ISSUE_995 | ||
| # COMMAND ${DYNAMIC_IMPLICITGEMM_WRW_ENVS_XDLOPS} $<TARGET_FILE:test_conv2d> ${MIOPEN_TEST_FLOAT_ARG} --verbose --input 1 3 32 32 --weights 1 3 11 11 --pads_strides_dilations 1 1 2 2 2 1 --disable-forward --disable-backward-data |
There was a problem hiding this comment.
Could we add a flag which indicates that cases only run for fp16?
These cases are not applicable for fp32.
There was a problem hiding this comment.
if you mean only these two tests, then we can separate them into an additional custom_test with such restrictions.
atamazov
added a commit
that referenced
this pull request
Jul 22, 2021
…t_regression_half_vega. W/A for #995 and #996 (#991) - Added: Workarounds for #995 and #996 - Fixes the following issues in tests: - Issue: `test_conv_igemm_dynamic_xdlops_bwd` does not test the HALF type. - Issue: `test_conv_igemm_dynamic_xdlops_fwd` does not test the HALF type. - Issue: `test_conv_igemm_dynamic_xdlops_wrw` does not test the HALF type. - Issue: `test_regression_half_vega` does nothing. - [Jenkinsfile] Added dedicated build param for FP16/BF16/INT8 Smoke tests - [NFC] Removed some useless if's.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test_conv_igemm_dynamic_xdlops_bwddoes not test the HALF type.test_conv_igemm_dynamic_xdlops_fwddoes not test the HALF type.test_conv_igemm_dynamic_xdlops_wrwdoes not test the HALF type.test_regression_half_vegadoes nothing.