Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix restrictions for vecload condition (iGemm v4r1 Bwd, 1x1) #933

Merged
merged 3 commits into from
May 20, 2021

Conversation

shaojiewang
Copy link
Contributor

@shaojiewang shaojiewang commented May 16, 2021

To fix issue: #917

test by :

MIOPEN_FIND_MODE=normal MIOPEN_DEBUG_FIND_ONLY_SOLVER=ConvHipImplicitGemmBwdDataV4R1Xdlops MIOPEN_LOG_LEVEL=5 ./bin/test_conv2d --half --input 8 16 14 14 --weights 32 16 1 1 -v --disable-backward-weights --disable-forward --pads_strides_dilations 1 1 1 1 1 1

and get output:

./bin/test_conv2d --half --cmode conv --pmode default --group-count 1 --disable-forward --disable-backward-weights --input 8, 16, 14, 14 --weights 32, 16, 1, 1 --pads_strides_dilations 1 1 1 1 1 1 --trans_output_pads 0 0 --in_layout NCHW --fil_layout NCHW --out_layout NCHW
error: 0
Max diff: 0
Backward convolution: ConvHipImplicitGemmBwdDataV4R1Xdlops
Input tensor: 8, 16, 14, 14
Weights tensor: 32, 16, 1, 1
Output tensor: 8, 32, 16, 16

@asleepzzz
Copy link
Contributor

./bin/MIOpenDriver conv -n 4 -c 64 --in_d 16 -H 56 -W 56 -k 64 --fil_d 1 -y 1 -x 1 --pad_d 0 -p 0 -q 0 --conv_stride_d 1 -u 1 -v 1 --dilation_d 1 -l 1 -j 1 --spatial_dim 3 -m conv -g 1 -F 2 -t 1 -s 1

./bin/MIOpenDriver conv -n 4 -c 64 --in_d 16 -H 56 -W 56 -k 256 --fil_d 1 -y 1 -x 1 --pad_d 0 -p 0 -q 0 --conv_stride_d 1 -u 1 -v 1 --dilation_d 1 -l 1 -j 1 --spatial_dim 3 -m conv -g 1 -F 2 -t 1 -s 1
./bin/MIOpenDriver conv -n 4 -c 256 --in_d 16 -H 56 -W 56 -k 64 --fil_d 1 -y 1 -x 1 --pad_d 0 -p 0 -q 0 --conv_stride_d 1 -u 1 -v 1 --dilation_d 1 -l 1 -j 1 --spatial_dim 3 -m conv -g 1 -F 2 -t 1 -s 1
./bin/MIOpenDriver conv -n 4 -c 256 --in_d 16 -H 56 -W 56 -k 128 --fil_d 1 -y 1 -x 1 --pad_d 0 -p 0 -q 0 --conv_stride_d 1 -u 1 -v 1 --dilation_d 1 -l 1 -j 1 --spatial_dim 3 -m conv -g 1 -F 2 -t 1 -s 1
./bin/MIOpenDriver conv -n 4 -c 256 --in_d 16 -H 56 -W 56 -k 512 --fil_d 1 -y 1 -x 1 --pad_d 0 -p 0 -q 0 --conv_stride_d 2 -u 2 -v 2 --dilation_d 1 -l 1 -j 1 --spatial_dim 3 -m conv -g 1 -F 2 -t 1 -s 1
./bin/MIOpenDriver conv -n 4 -c 128 --in_d 8 -H 28 -W 28 -k 512 --fil_d 1 -y 1 -x 1 --pad_d 0 -p 0 -q 0 --conv_stride_d 1 -u 1 -v 1 --dilation_d 1 -l 1 -j 1 --spatial_dim 3 -m conv -g 1 -F 2 -t 1 -s 1
./bin/MIOpenDriver conv -n 4 -c 512 --in_d 8 -H 28 -W 28 -k 128 --fil_d 1 -y 1 -x 1 --pad_d 0 -p 0 -q 0 --conv_stride_d 1 -u 1 -v 1 --dilation_d 1 -l 1 -j 1 --spatial_dim 3 -m conv -g 1 -F 2 -t 1 -s 1
./bin/MIOpenDriver conv -n 4 -c 512 --in_d 8 -H 28 -W 28 -k 256 --fil_d 1 -y 1 -x 1 --pad_d 0 -p 0 -q 0 --conv_stride_d 1 -u 1 -v 1 --dilation_d 1 -l 1 -j 1 --spatial_dim 3 -m conv -g 1 -F 2 -t 1 -s 1
./bin/MIOpenDriver conv -n 4 -c 512 --in_d 8 -H 28 -W 28 -k 1024 --fil_d 1 -y 1 -x 1 --pad_d 0 -p 0 -q 0 --conv_stride_d 2 -u 2 -v 2 --dilation_d 1 -l 1 -j 1 --spatial_dim 3 -m conv -g 1 -F 2 -t 1 -s 1
./bin/MIOpenDriver conv -n 4 -c 256 --in_d 4 -H 14 -W 14 -k 1024 --fil_d 1 -y 1 -x 1 --pad_d 0 -p 0 -q 0 --conv_stride_d 1 -u 1 -v 1 --dilation_d 1 -l 1 -j 1 --spatial_dim 3 -m conv -g 1 -F 2 -t 1 -s 1
./bin/MIOpenDriver conv -n 4 -c 1024 --in_d 4 -H 14 -W 14 -k 256 --fil_d 1 -y 1 -x 1 --pad_d 0 -p 0 -q 0 --conv_stride_d 1 -u 1 -v 1 --dilation_d 1 -l 1 -j 1 --spatial_dim 3 -m conv -g 1 -F 2 -t 1 -s 1
./bin/MIOpenDriver conv -n 4 -c 1024 --in_d 4 -H 14 -W 14 -k 512 --fil_d 1 -y 1 -x 1 --pad_d 0 -p 0 -q 0 --conv_stride_d 1 -u 1 -v 1 --dilation_d 1 -l 1 -j 1 --spatial_dim 3 -m conv -g 1 -F 2 -t 1 -s 1

@codecov

This comment has been minimized.

@atamazov atamazov marked this pull request as draft May 17, 2021 14:47
@atamazov
Copy link
Contributor

Converted to draft for now. @shaojiewang please click [Ready for review] when PR is ready.

@atamazov atamazov added the bug label May 17, 2021
@atamazov atamazov changed the title add some restriction for vecload condition Fix restrictions for vecload condition May 17, 2021
@atamazov
Copy link
Contributor

Let's make this PR ASAP. It's worth fixing #936 ASAP as well. Thus, we will be ready to deliver a hot fix to the ROCm 4.3 Release branch if urgent need arise.

/cc @asroy @junliume @asleepzzz @shurale-nkn

@shaojiewang shaojiewang marked this pull request as ready for review May 19, 2021 01:33
@shaojiewang shaojiewang requested review from asroy, atamazov, asleepzzz and shurale-nkn and removed request for asroy and atamazov May 19, 2021 01:38
@shaojiewang
Copy link
Contributor Author

@atamazov @asleepzzz @shurale-nkn You could review code if available.

Copy link
Contributor

@asleepzzz asleepzzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shaojiewang shaojiewang requested a review from junliume May 20, 2021 10:13
Copy link
Contributor

@shurale-nkn shurale-nkn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@atamazov atamazov changed the title Fix restrictions for vecload condition Fix restrictions for vecload condition (iGemm v4r1 Bwd, 1x1) May 20, 2021
@atamazov atamazov merged commit d2de2fd into develop May 20, 2021
@atamazov atamazov deleted the fix_1x1_pad_1_v4r1_bwd_pass_issue branch June 23, 2021 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants