Bg/fix bn solvers is applicable #3355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/fix_bn_solvers_is_applicable
* add type checks to other ocl solvers * fix other minor issues
BrianHarrisonAMD
added a commit
that referenced
this pull request
Nov 2, 2024
* Add bfloat16 support to OCL bn kernels * Fix issue * Fix spacing * Add bf16 support for bwd OCL spatial * Further changes of OCL kernels for bfp16 * Add bf16 support for remaining OCL solvers * Fix compilation error * Fix compilation errors * Fix formatting * Fix extra bracket being added * Fix kernel compilation and issue with variant selection for BF16 mixed * Swap solver order to prefer OCL over CK by default * Update batchnorm bfp16mix to match fp16mix declaration * Fix improper cast * Fix formatting * Fix kernel typo for activ * Bg/fix bn solvers is applicable (#3355) * fix driver for old ocl kernel * fix template name * fix review comments * fix isApplicable for CK and OCL bn spatial * fix gtest issue in bn for ck and ocl * fix minor issue * fix clang format * hip tidy * fix gtest sample and fix hiptidy * * move type check logic to problem description of batch norm * add type checks to other ocl solvers * fix other minor issues * fix network cache * fix minor testing issue * disable ck bn for now --------- Co-authored-by: BrianHarrisonAMD <[email protected]> * Fix formatting --------- Co-authored-by: Brad Pepers <[email protected]> Co-authored-by: bibek <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix Gtest for ock and ck kernel for batch norm
fix driver cmd