Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test non-packed inputs with naive reference convolution kernels #2394

Merged
merged 38 commits into from
Oct 12, 2023
Merged
Changes from 1 commit
Commits
Show all changes
38 commits
Select commit Hold shift + click to select a range
94f5fd3
Squash commits together
amberhassaan Aug 20, 2023
5ab82f3
fix formatting. disable strides for fp8 kernel for now
amberhassaan Sep 23, 2023
be93522
fix the lengths of weight tensor
amberhassaan Sep 23, 2023
d85785b
use 64-bit integers for stride value
amberhassaan Sep 25, 2023
ee6abb3
Squash commits together
amberhassaan Aug 20, 2023
4fbcd77
fix test for non-packed strides
amberhassaan Sep 18, 2023
82e0ccf
fix format
amberhassaan Sep 18, 2023
7e8a258
Fix assertion check.
amberhassaan Sep 18, 2023
cadfb95
suppress cppcheck warning to test CI
junliume Sep 20, 2023
cde6e22
fix build and remove a check that prevents non-strided inputs
amberhassaan Sep 25, 2023
f7b606b
Merge remote-tracking branch 'origin/develop' into amber/non-packed-c…
amberhassaan Sep 25, 2023
0ad674b
Merge branch 'amber/non-packed-conv-ref-kern' into amber/tests-non-pa…
amberhassaan Sep 25, 2023
4db6cf8
Merge remote-tracking branch 'origin/develop' into amber/non-packed-c…
amberhassaan Sep 25, 2023
8af6d47
Merge branch 'amber/non-packed-conv-ref-kern' into amber/tests-non-pa…
amberhassaan Sep 25, 2023
e06c523
addressed comments. Moved common code into an include file
amberhassaan Sep 26, 2023
23d0066
Merge remote-tracking branch 'origin/develop' into amber/non-packed-c…
amberhassaan Sep 26, 2023
35c9072
Merge branch 'amber/non-packed-conv-ref-kern' into amber/tests-non-pa…
amberhassaan Sep 26, 2023
67d9a77
address comments
amberhassaan Sep 26, 2023
0f16c62
address review comments
amberhassaan Sep 28, 2023
c66da71
Merge remote-tracking branch 'origin/develop' into amber/non-packed-c…
amberhassaan Sep 28, 2023
8bb3a7f
Merge branch 'amber/non-packed-conv-ref-kern' into amber/tests-non-pa…
amberhassaan Sep 28, 2023
dec88a7
add more checks for strides
amberhassaan Sep 29, 2023
700b623
Merge remote-tracking branch 'origin/develop' into amber/non-packed-c…
amberhassaan Oct 2, 2023
1253aed
Merge branch 'amber/non-packed-conv-ref-kern' into amber/tests-non-pa…
amberhassaan Oct 2, 2023
85e8a62
fix test now that strides are supported
amberhassaan Oct 3, 2023
39eee97
use C++17 to compile HIP Kernels
amberhassaan Oct 4, 2023
f60f182
Merge remote-tracking branch 'origin/develop' into amber/non-packed-c…
amberhassaan Oct 4, 2023
e7c9d03
Merge branch 'amber/non-packed-conv-ref-kern' into amber/tests-non-pa…
amberhassaan Oct 4, 2023
57fdf6e
address comments
amberhassaan Oct 4, 2023
e8dbc49
Merge branch 'develop' into amber/tests-non-packed-conv
junliume Oct 8, 2023
b5d8b0f
address comments
amberhassaan Oct 4, 2023
0fe1a55
remove OpenCL code due to deprecation
amberhassaan Oct 4, 2023
1cab2c3
Merge branch 'amber/non-packed-conv-ref-kern' into amber/tests-non-pa…
amberhassaan Oct 9, 2023
505f6ab
fix build
amberhassaan Oct 9, 2023
c34c72a
fix Clang Format issue
junliume Oct 9, 2023
e146046
Merge remote-tracking branch 'origin/develop' into amber/tests-non-pa…
amberhassaan Oct 11, 2023
220e423
resolve conflicts and handle feedback
amberhassaan Oct 11, 2023
baa2da4
advance fin
amberhassaan Oct 11, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
suppress cppcheck warning to test CI
junliume authored and amberhassaan committed Sep 25, 2023
commit cadfb9583040ce36ed5c7b8960bacffa053bcb8a
1 change: 1 addition & 0 deletions test/gpu_reference_kernel.cpp
Original file line number Diff line number Diff line change
@@ -330,6 +330,7 @@ void pad_tensor_strides(std::vector<int>& strides)
// int c = 2;
for(auto& v : strides)
{
// cppcheck-suppress useStlAlgorithm
v = v * c;
amberhassaan marked this conversation as resolved.
Show resolved Hide resolved
}
pvec("new strides", strides);