[HotFix] Fix build issue after #2286 #2328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iq136boy
approved these changes
Aug 16, 2023
|
@junliume @JehandadKhan Please merge this ASAP to unblock CI. |
|
@atamazov Waiting on the CI to pass. |
junliume
approved these changes
Aug 17, 2023
|
It passed the stage where it failed before, thanks for the quick catch! |
cderb
added a commit
that referenced
this pull request
Sep 18, 2023
* 3D group forward convolution solver (#2286) * [HotFix] Fix build issue after #2286 (#2328) * Fix ConvCkIgemmFwdV6r1DlopsNchw solver to reflect that it's not dynamic (#2325) * Remove target IDs from kdb entries (#2309) * Dropout: make seed and states_num kernel arguments (#2277) * [MI250] Adding missing kernel objects (#2329) * Post-merge fixups: Replace environment variable check with problem config check and reduce lambda capture for Invoker obj (#2305) * [HotFix][CI] fix HIP tidy issue from #2277 (#2335) * [HotFix] Update requirements.txt MLIR ignore PATH for Python conda LLD (#2324) * [NFC] Replace long integers with int64_t and size_t for better compatibility with Windows (#2323) * Windows compatibility: replace long integers with int64_t and size_t, replace uint with unsigned int, replace long with long long for numbers, proper casting * Fix formatting * Fix 3d group forward convolution * Resolve review comments * Fix formatting --------- Co-authored-by: Daming Feng <[email protected]> Co-authored-by: Evgenii Averin <[email protected]> Co-authored-by: JD <[email protected]> Co-authored-by: Tal Ben-Nun <[email protected]> Co-authored-by: amberhassaan <[email protected]> Co-authored-by: Jun Liu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Compilation has been broken by merging #2295 and #2286