Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix missing DetectRocm() in FindSolutionsImpl(), where options = nullptr #2288

Merged
merged 1 commit into from
Aug 2, 2023

Conversation

carlushuang
Copy link
Contributor

@carlushuang carlushuang commented Aug 1, 2023

This will fix SWDEV-404537

We people use miopenFindSolutoins() API with options = nullptr, will have GPU crash if MIOPEN_FIND_ENFORCE=4

The root cause is there is no workspace allocated while tuning, since when call GetWorkspace() every asm solver will return not applicable, but when launching the kernel they will return applicable, and run the kernel with nullptr workspace.
This PR fix this issue.

image

Copy link
Contributor

@atamazov atamazov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good as a hot fix!

@carlushuang Thanks for this finding. Can you propose some regression test (or just describe what needs to be done and in what order)?

@junliume
Copy link
Contributor

junliume commented Aug 2, 2023

Good as a hot fix!

@carlushuang Thanks for this finding. Can you propose some regression test (or just describe what needs to be done and in what order)?

@atamazov there is no good way of reproducing it in MIOpenDriver, actually it is not found when running migrtaphx-driver. Maybe there is a way to reproduce in Find 2.0 path @DrizztDoUrden ?

@carlushuang
Copy link
Contributor Author

Agreed with Jun. MIOpenDriver has different code path to utilize internal APIs, in this case miopenFindSolutoins(options=nullptr) can only fire the bug.
@atamazov I guess just test the API level with options = nullptr and not nullptr?

@junliume junliume merged commit a84ad36 into develop Aug 2, 2023
@junliume junliume deleted the fix_missing_detectrocm_in_findsolutions branch August 28, 2023 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants