Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOTFIX] disable ctest for ConvAsmImplicitGemmGTCDynamicFwdXdlops #1639

Merged
merged 1 commit into from
Jul 21, 2022

Conversation

carlushuang
Copy link
Contributor

in PR #1619 we disable ConvAsmImplicitGemmGTCDynamicFwdXdlops, but not close it in ctest. This will cause issue #1638 .This PR is a hot fix for issue.

@carlushuang carlushuang requested a review from junliume July 21, 2022 05:21
@codecov

This comment was marked as off-topic.

@junliume
Copy link
Contributor

in PR #1619 we disable ConvAsmImplicitGemmGTCDynamicFwdXdlops, but not close it in ctest. This will cause issue #1638 .This PR is a hot fix for issue.

@carlushuang thanks for the W/A. Could we also establish a new issue so that we can track progress on fixing this kernel? I assume we need to remove this workaround in a later time.

@junliume
Copy link
Contributor

in PR #1619 we disable ConvAsmImplicitGemmGTCDynamicFwdXdlops, but not close it in ctest. This will cause issue #1638 .This PR is a hot fix for issue.

@carlushuang thanks for the W/A. Could we also establish a new issue so that we can track progress on fixing this kernel? I assume we need to remove this workaround in a later time.

I need to merge this to unblock develop branch, while please keep an eye on the post-merge action items.

@junliume junliume merged commit 4261d52 into develop Jul 21, 2022
@junliume junliume deleted the hot_fix_issue_1638 branch October 10, 2022 23:45
COMMAND ${DYNAMIC_IMPLICITGEMM_FWD_GTC_DYNAMIC_XDLOPS_ENVS} $<TARGET_FILE:test_conv2d> ${MIOPEN_TEST_FLOAT_ARG} --verbose --input 64 3 224 224 --weights 64 3 7 7 --pads_strides_dilations 3 3 2 2 1 1 --disable-backward-data --disable-backward-weights
COMMAND ${DYNAMIC_IMPLICITGEMM_FWD_GTC_DYNAMIC_XDLOPS_ENVS} $<TARGET_FILE:test_conv2d> ${MIOPEN_TEST_FLOAT_ARG} --verbose --input 64 3 230 230 --weights 64 3 7 7 --pads_strides_dilations 0 0 2 2 1 1 --disable-backward-data --disable-backward-weights
)
#add_custom_test(test_conv_igemm_dynamic_xdlops_fwd SKIP_UNLESS_ALL HALF_ENABLED GFX90A_DISABLED GFX900_DISABLED GFX906_DISABLED SKIP_XNACK_ON
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add

# Commented out due to WORKAROUND_SWDEV_306318

at least

@qianfengz
Copy link
Contributor

It looks some tests for non 1x1 filters also removed by this P.R

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants