[HOTFIX][SWDEV-326460] check MIOPEN_DEBUG_CONVOLUTION_DETERMINISTIC in IsApplicable() #1451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlushuang
requested review from
JehandadKhan,
junliume,
asroy,
zjing14 and
shaojiewang
|
blocked by #1452, CI will not pass Update: fixed |
This comment was marked as off-topic.
This comment was marked as off-topic.
shaojiewang
reviewed
Mar 8, 2022
shaojiewang
approved these changes
Mar 8, 2022
junliume
approved these changes
Mar 8, 2022
|
@carlushuang I am Ok with this PR, but can you please comment out was is wrong with #1377?
We can, and the library will use the default tuning config instead. The cost is a warning message. |
|
@JehandadKhan @asroy @zjing14 @atamazov last call for reviewers :) Plan to merge and cherry pick later today 03/08. |
atamazov
approved these changes
Mar 8, 2022
|
I highly recommend renaming this PR in order to include "(SWDEV-316705)" into commit name. |
junliume
changed the title
junliume
added a commit
that referenced
this pull request
Mar 8, 2022
…n IsApplicable() (#1451) * check MIOPEN_DEBUG_CONVOLUTION_DETERMINISTIC in IsApplicable() Co-authored-by: Jun Liu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an hot fix for SWDEV-316705
Due to our current design, if a solver has multiple configs, and some of the config support deterministic(e.g. non-deterministic), some are not, we can not disable a single config in
IsValid()function. But We need disable it inIsApplicable(), which means will disable this solver entirely ifMIOPEN_DEBUG_CONVOLUTION_DETERMINISTICenv var is set.This may have a performance impact, but since currently this env var is for test purpose (in this case performance impact is OK per our customer), so this approach is simple and fine.
If in future has performance requirement under
MIOPEN_DEBUG_CONVOLUTION_DETERMINISTIC, need to seek for other approach and implementation.