[TUNA] FIN subtree updates JSON versioning #1376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0e164bf66 setting json version (#37) f3f7fed18 Remove function redefinition (#36) e1de51a58 Performance DB de-serialize test (#34) 043cdcdaa Layout support in Fin (#33) 3a1d58236 Hotfix (#32) ee3f0d543 4.4 Tuning Bugfixes (#31) 832dbe234 Tunability Reporting (#27) a564a229f include gfx90a_110 (#28) git-subtree-dir: fin git-subtree-split: 0e164bf66280932586e25e15d09c60b02cbd6fc3
junliume
reviewed
Jan 14, 2022
| @@ -994,17 +994,25 @@ int ConvFin<Tgpu, Tref>::ProcessStep(const std::string& step_name) | |||
| if(step_name == "copy_buf_from_device") | |||
| return CopyFromDevice(); | |||
| if(step_name == "applicability") | |||
| { | |||
There was a problem hiding this comment.
@alexandraBara why this change? Or why not change them all? :)
JehandadKhan
approved these changes
Jan 14, 2022
|
@alexandraBara Please check the CI |
Codecov Report
@@ Coverage Diff @@
## develop #1376 +/- ##
========================================
Coverage 50.67% 50.67%
========================================
Files 359 359
Lines 53765 53765
========================================
Hits 27248 27248
Misses 26517 26517 Continue to review full report at Codecov.
|
junliume
changed the title
|
It should not have impacted CI while the pipeline keep stuck for other reasons. Restarted again and let's monitor it. |
junliume
approved these changes
Jan 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pulled in the most recent version of FIN https://github.com/ROCmSoftwarePlatform/fin: