-
Notifications
You must be signed in to change notification settings - Fork 237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Use use_hip_kernels
and use_asm_kernels
in Naive convolution Solvers
#1323
Conversation
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see #1323 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@JehandadKhan test_find_db somehow failed for this PR, no obvious errors in the log except |
@carlushuang @atamazov this test is passing on develop branch and consistently fails with this PR |
Yeah, that is possible since OCL and HIP kernels are disabled... |
Just after this: #if WORKAROUND_SWDEV_292187
setenv("MIOPEN_DEBUG_HIP_KERNELS", "1", 1);
setenv("MIOPEN_DEBUG_OPENCL_CONVOLUTIONS", "1", 1);
#endif You may also need to |
Now the side effect of this PR is that it disables Naive Solvers (in some cases at least), and we may encounter a number of unexpected issues later (the test_find_db is just an early sign). It seems like we need to replace the "MIOPEN_DEBUG_HIP_KERNELS=0" workaround from #1329 with disabling HIP solvers on individual basis (and this way keep Naive Solvers enabled). I recommend implementing this right here. After that, the W/A in test_find_db won't be needed. |
Actually it may be even better to put this PR on hold. I am going to investigate SWDEV-292187, narrow the existing W/A (from #1329) and create a new PR. At the very beginning of that work, I'll need HIP solvers individually disabled (instead of global switch). This is the same change as I just proposed to do in this PR. So let's save efforts, and wait several days. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Block merging due to #1323 (comment)
use_hip_kernels
and use_asm_kernels
in Naive convolution Solvers
Now blocked only by #1398 + update from develop. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
this fix #1319