[NFC] Post review of #1230: Asm igemm nhwc native bf16 kernel on gfx90a #1248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…. remove reference binding to temporary
This comment has been minimized.
This comment has been minimized.
|
@shaojiewang Thanks for the quick actions! Please check the tasks in: and if all tasks are completed in this PR, please mark it ready for review :) |
Yes, sure. |
3 tasks
shaojiewang
changed the title
atamazov
previously requested changes
Nov 3, 2021
Co-authored-by: Artem Tamazov <[email protected]>
junliume
dismissed
atamazov’s stale review
Changed made as suggested. CI should consider as passed since last changes are mostly cosmetic.
junliume
previously approved these changes
Nov 4, 2021
shaojiewang
dismissed stale reviews from carlushuang and junliume
via
5b9293f
|
conflicts resolved |
junliume
approved these changes
Nov 7, 2021
|
@atamazov gentle ping for review input on this one :) |
atamazov
reviewed
Nov 8, 2021
atamazov
reviewed
Nov 8, 2021
atamazov
changed the title
let's move to #1230 (comment) |
junliume
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix post review comment of #1230.
Note: Post review of #1227 will be fixed within #1247 by @carlushuang.
Clarification by @atamazov: This should resolve bullets (2) and (3) from #1241. No Functional Changes.