-
Notifications
You must be signed in to change notification settings - Fork 242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOTFIX][4.5] Logging Warning->Info when PerfConfigs from db can't be deserialized or invalid (SWDEV-288975) #1214
Conversation
This comment has been minimized.
This comment has been minimized.
@JehandadKhan This should be merged into staging branch, isn't it? |
@JehandadKhan And PR title should contain not [4.1.x] but [4.5], right? |
This PR only works for records that have incorrect format (e.g. incorrect number of comma-separated-numbers). But there could be records that have correct format but invalid from the Solver's point of view ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please go ahead if this works for you as is.
@JehandadKhan Please let me know if you need more assistance; I can polish this PR for you. |
It might be late for Central Time zone (and reaaaaly late for your time zone) while still okay for me, I am making changes according to your advice now. Update: @atamazov if you have it already please make those changes :) |
… deserialized (SWDEV-288975)
@atamazov Please go ahead |
I'll look here tomorrow SPB morning and make changes if necessary ;) |
I made some preliminary changes in order to kick off another round of CI. |
@junliume @JehandadKhan If you want to merge directly to the release branch, then please cherry-pick the same also into staging -- let's keep both in sync, so we'll be able to add more commits to staging and merge into release, if need arise. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
… deserialized or invalid (SWDEV-288975) (#1214) * warning to info for invalid perf db entries * [HOTFIX][4.5] Logging Warning->Info when PerfConfigs from db can't be deserialized (SWDEV-288975) Co-authored-by: Jun Liu <[email protected]>
Done for both release/rocm-rel-4.5-staging-verified (the one actually merged into release/rocm-rel-4.5) and release/rocm-rel-4.5-staging (the one has DB updates to remove solver 2c73a4f) |
@junliume Good!
I think we do not need release/rocm-rel-4.5-staging-verified branch anymore. This is just an ordinary branch that can be deleted after #1210 is merged in. We can use the promotion procedure (directly from the staging branch) as discussed in mail. |
I just cherry-picked #1211 is into |
… deserialized or invalid (SWDEV-288975) (#1214) * warning to info for invalid perf db entries * [HOTFIX][4.5] Logging Warning->Info when PerfConfigs from db can't be deserialized (SWDEV-288975) Co-authored-by: Jun Liu <[email protected]>
No description provided.