Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOTFIX][4.5] Logging Warning->Info when PerfConfigs from db can't be deserialized or invalid (SWDEV-288975) #1214

Merged
merged 2 commits into from
Oct 8, 2021

Conversation

JehandadKhan
Copy link
Contributor

No description provided.

@codecov

This comment has been minimized.

@junliume junliume requested a review from atamazov October 7, 2021 18:14
@atamazov
Copy link
Contributor

atamazov commented Oct 7, 2021

@JehandadKhan This should be merged into staging branch, isn't it?

@atamazov
Copy link
Contributor

atamazov commented Oct 7, 2021

@JehandadKhan And PR title should contain not [4.1.x] but [4.5], right?

@atamazov atamazov added this to the ROCm 4.5 milestone Oct 7, 2021
@atamazov
Copy link
Contributor

atamazov commented Oct 7, 2021

This PR only works for records that have incorrect format (e.g. incorrect number of comma-separated-numbers). But there could be records that have correct format but invalid from the Solver's point of view (solver::IsValidPerformanceConfig() returns false). I recommend borrowing also #746, which resolves the latter problem.

Copy link
Contributor

@atamazov atamazov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please go ahead if this works for you as is.

src/include/miopen/db_record.hpp Outdated Show resolved Hide resolved
@atamazov
Copy link
Contributor

atamazov commented Oct 7, 2021

@JehandadKhan Please let me know if you need more assistance; I can polish this PR for you.

@junliume
Copy link
Contributor

junliume commented Oct 7, 2021

@JehandadKhan Please let me know if you need more assistance; I can polish this PR for you.

It might be late for Central Time zone (and reaaaaly late for your time zone) while still okay for me, I am making changes according to your advice now.

Update: @atamazov if you have it already please make those changes :)

@JehandadKhan
Copy link
Contributor Author

@JehandadKhan Please let me know if you need more assistance; I can polish this PR for you.

@atamazov Please go ahead

@atamazov
Copy link
Contributor

atamazov commented Oct 7, 2021

I'll look here tomorrow SPB morning and make changes if necessary ;)

@junliume junliume changed the title [HOTFIX][4.1.x] Logging Warning->Info when PerfConfigs from db can't be deserialized (SWDEV-288975) [HOTFIX][4.5] Logging Warning->Info when PerfConfigs from db can't be deserialized (SWDEV-288975) Oct 7, 2021
@junliume
Copy link
Contributor

junliume commented Oct 7, 2021

I'll look here tomorrow SPB morning and make changes if necessary ;)

I made some preliminary changes in order to kick off another round of CI.

@atamazov
Copy link
Contributor

atamazov commented Oct 8, 2021

@JehandadKhan This should be merged into staging branch, isn't it?

@junliume @JehandadKhan If you want to merge directly to the release branch, then please cherry-pick the same also into staging -- let's keep both in sync, so we'll be able to add more commits to staging and merge into release, if need arise.

@atamazov atamazov changed the title [HOTFIX][4.5] Logging Warning->Info when PerfConfigs from db can't be deserialized (SWDEV-288975) [HOTFIX][4.5] Logging Warning->Info when PerfConfigs from db can't be deserialized or invalid (SWDEV-288975) Oct 8, 2021
Copy link
Contributor

@atamazov atamazov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@junliume junliume merged commit 269f974 into release/rocm-rel-4.5 Oct 8, 2021
junliume added a commit that referenced this pull request Oct 8, 2021
… deserialized or invalid (SWDEV-288975) (#1214)

* warning to info for invalid perf db entries

* [HOTFIX][4.5] Logging Warning->Info when PerfConfigs from db can't be deserialized (SWDEV-288975)

Co-authored-by: Jun Liu <[email protected]>
@junliume
Copy link
Contributor

junliume commented Oct 8, 2021

@JehandadKhan This should be merged into staging branch, isn't it?

@junliume @JehandadKhan If you want to merge directly to the release branch, then please cherry-pick the same also into staging -- let's keep both in sync, so we'll be able to add more commits to staging and merge into release, if need arise.

Done for both release/rocm-rel-4.5-staging-verified (the one actually merged into release/rocm-rel-4.5) and release/rocm-rel-4.5-staging (the one has DB updates to remove solver 2c73a4f)

@atamazov
Copy link
Contributor

atamazov commented Oct 8, 2021

@junliume Good!

Done for both release/rocm-rel-4.5-staging-verified (the one actually merged into release/rocm-rel-4.5)

I think we do not need release/rocm-rel-4.5-staging-verified branch anymore. This is just an ordinary branch that can be deleted after #1210 is merged in.

We can use the promotion procedure (directly from the staging branch) as discussed in mail.

@atamazov
Copy link
Contributor

atamazov commented Oct 8, 2021

@junliume

Done for ... release/rocm-rel-4.5-staging (the one has DB updates to remove solver 2c73a4f)

I just cherry-picked #1211 is into release/rocm-rel-4.5-staging. Now 4.5 release staging has W/A for SWDEV-305815 identical to the one that resides in develop (the most "valid" one!), ready for promotion into 4.5 release, just in case if need arise.

@JehandadKhan JehandadKhan deleted the getvalues-warning2info-rocm45x branch December 6, 2021 19:49
junliume added a commit that referenced this pull request Mar 3, 2022
… deserialized or invalid (SWDEV-288975) (#1214)

* warning to info for invalid perf db entries

* [HOTFIX][4.5] Logging Warning->Info when PerfConfigs from db can't be deserialized (SWDEV-288975)

Co-authored-by: Jun Liu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants