Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NFC] ConvolutionContext made accessible in SetNextValue() #1033

Merged
merged 2 commits into from
Jul 14, 2021

Conversation

atamazov
Copy link
Contributor

Implements ticket #388 (also promised at #1018 (comment)). Some non-robust code eliminated at once.

Added many reviewers just to inform all potentially interested.

@atamazov atamazov changed the title ConvolutionContext made accessible in SetNextValue() [NFC] ConvolutionContext made accessible in SetNextValue() Jul 13, 2021
@codecov

This comment has been minimized.

Copy link
Contributor

@DrizztDoUrden DrizztDoUrden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@atamazov atamazov merged commit 9e6cf55 into develop Jul 14, 2021
@atamazov atamazov deleted the improve-setnextvalue branch July 14, 2021 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants