-
Notifications
You must be signed in to change notification settings - Fork 236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MI100][FP16][ASM iGemm] Fix wrw's very small ho and wo error #1000
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix merge conflicts and revert W/A for #996
Merged. |
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost almost done
CI run |
@JehandadKhan @junliume This PR adds a new parameter to kernels, thus making 4.3 precompiled kernels package for MI100 incompatible with current develop (and with MIOpen Mainline when this change gets merged there). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@atamazov Please let me know when this gets promoted to mainline |
@JehandadKhan I will try to not forget about it. Please also try to keep an eye on the "MIOpen promotion: Mainline" mail thread. "PR #1000" is easy to remember ;) |
- Fix asm igemm wrw hoxwo less than b_padding bug - [TESTS] Revert W/A for issue #996
fix #996
fix asm igemm wrw hoxwo less than b_padding bug.