Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MI100][FP16][ASM iGemm] Fix wrw's very small ho and wo error #1000

Merged
merged 4 commits into from
Jun 24, 2021

Conversation

shaojiewang
Copy link
Contributor

fix #996
fix asm igemm wrw hoxwo less than b_padding bug.

Copy link
Contributor

@atamazov atamazov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix merge conflicts and revert W/A for #996

@shaojiewang
Copy link
Contributor Author

Please fix merge conflicts and revert W/A for #996

Merged.

@codecov

This comment has been minimized.

Copy link
Contributor

@atamazov atamazov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost almost done

test/CMakeLists.txt Outdated Show resolved Hide resolved
@atamazov
Copy link
Contributor

CI run #2 has passed all the tests.

@atamazov
Copy link
Contributor

@JehandadKhan @junliume This PR adds a new parameter to kernels, thus making 4.3 precompiled kernels package for MI100 incompatible with current develop (and with MIOpen Mainline when this change gets merged there).

@atamazov atamazov added the bug label Jun 24, 2021
Copy link
Contributor

@atamazov atamazov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@atamazov atamazov merged commit a136372 into develop Jun 24, 2021
@atamazov atamazov changed the title [MI100][FP16]Fix wrw's very small ho and wo error [MI100][FP16][ASM iGemm] Fix wrw's very small ho and wo error Jun 24, 2021
@JehandadKhan
Copy link
Contributor

@atamazov Please let me know when this gets promoted to mainline

@atamazov
Copy link
Contributor

@JehandadKhan I will try to not forget about it. Please also try to keep an eye on the "MIOpen promotion: Mainline" mail thread. "PR #1000" is easy to remember ;)

atamazov pushed a commit that referenced this pull request Jul 22, 2021
- Fix asm igemm wrw hoxwo less than b_padding bug
- [TESTS] Revert W/A for issue #996
@atamazov atamazov deleted the fix_wrw_hoxwo_less_than_b_padding_bug branch July 23, 2021 23:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[MI100][Fp16] ConvAsmImplicitGemmGTCDynamicWrwXdlops fails validation
3 participants