Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly fix W/A from #240, commit 661308bd7 - [test_conv_for_implicit_gemm] Disable config that fails often. #1167

Open
Tracked by #1147
atamazov opened this issue Sep 22, 2021 · 3 comments

Comments

@atamazov
Copy link
Contributor

Commit that introduces the W/A: 661308b

Where it resides now: https://github.com/ROCmSoftwarePlatform/MIOpen/blob/2d7b2dd76464ac0fe052118718c4ab217341d25b/test/CMakeLists.txt#L723

Let's revert the W/A, check if problem still persists and provide a proper fix.

junliume added a commit that referenced this issue Sep 22, 2021
@junliume
Copy link
Contributor

Let's see what might or might not pass with this WA reverted:
http://micimaster.amd.com/blue/organizations/jenkins/MLLibs%2FMIOpen/detail/fix_%231167/1/pipeline/

@ppanchad-amd
Copy link

@atamazov, Is this ticket still relevant?

@atamazov
Copy link
Contributor Author

atamazov commented Apr 3, 2024

@ppanchad-amd Yes. The W/A was silently removed in #2513, however, in test/gtest/conv_for_implicit_gemm.cpp, we still need to re-enable the config mentioned in the description of this issue.

/cc @ozturkosu @junliume

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants