[HIPIFY][perl][#1776][#1823][fix] Return to using for each instead of while in some loops
#1843
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…instead of `while` in some loops [Reason] + Those `while` loops were actually not executed without any even warning from Perl + It looks like the `arrays` provided in `while` statements were treated as `maps` [Results] + Actual performance improvement is about 10%, instead of 450% hastily announced in ROCm#1823
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Reason]
whileloops were actually not executed without any even warning from Perlarraysprovided inwhilestatements were treated asmaps[Results]
10%, instead of450%, hastily announced in [HIPIFY][#1776][perl][feature][fix] Tuned thehipify-perlperformance up to450%#1823