Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HIPIFY][#674][#837][rocSPARSE][feature] rocSPARSE support - Step 32 - functions #1001

Merged
merged 1 commit into from
Aug 28, 2023

Conversation

emankov
Copy link
Collaborator

@emankov emankov commented Aug 28, 2023

  • Implemented a new function call transformation type "additional non-const arg" (e_add_var_argument)
  • The variable for the adding function argument is a copy of another function call argument
  • The new transformation is tested on rocSPARSE functions rocsparse_(s|d|c|z)gpsv_interleaved_batch, where:
    • an additional argument rocsparse_int batch_stride is copied from the previous one: rocsparse_int batch_count;
    • it is how hipsparse(S|D|C|Z)gpsvInterleavedBatch calls rocsparse_(s|d|c|z)gpsv_interleaved_batch in their implementation;
  • Updated synthetic tests and the regenerated hipify-perl and SPARSE docs

…Step 32 - functions

+ Implemented a new function call transformation type "additional non-const arg" (`e_add_var_argument`)
+ The variable for the adding function argument is a copy of another function call argument
+ The new transformation is tested on rocSPARSE functions `rocsparse_(s|d|c|z)gpsv_interleaved_batch`, where:
  - an additional argument rocsparse_int batch_stride is copied from the previous one: rocsparse_int batch_count;
  - it is how hipsparse(S|D|C|Z)gpsvInterleavedBatch calls rocsparse_(s|d|c|z)gpsv_interleaved_batch in its implementation;
+ Updated synthetic tests and the regenerated hipify-perl and SPARSE docs
@emankov emankov added feature Feature request or implementation sync Syncing update rocSPARSE rocSPARSE-related labels Aug 28, 2023
@emankov emankov requested a review from searlmc1 August 28, 2023 16:58
@emankov emankov self-assigned this Aug 28, 2023
@emankov emankov merged commit 64a61cd into ROCm:amd-staging Aug 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Feature request or implementation rocSPARSE rocSPARSE-related sync Syncing update
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant