Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[HIPIFY][feature] Support for fp8 data types #1617

Closed
foreverlms opened this issue Aug 14, 2024 · 5 comments
Closed

[HIPIFY][feature] Support for fp8 data types #1617

foreverlms opened this issue Aug 14, 2024 · 5 comments
Assignees
@emankov
Labels
device device API-related feature Feature request or implementation

Comments

@foreverlms
Copy link

Problem Description

Such as when I hipify a cu file having fp8 datatype in it, after the hipify-clang command, the fp8 datatype doesn't turned into HIP fp8 type.

For example:

__nv_fp8_e4m3

doesn't change and the hipify-clang will report error:

 error: unknown type name '__nv_fp8_e4m3'

Why? Doesn't hipify support FP8?

Operating System

Ubuntu 20.04.6 LTS (Focal Fossa)

CPU

AMD EPYC 7643 48-Core Processor

ROCm Version

ROCm 6.0.0

ROCm Component

HIPIFY

Steps to Reproduce

No response

(Optional for Linux users) Output of /opt/rocm/bin/rocminfo --support

No response

Additional Information

No response
@emankov emankov self-assigned this Aug 14, 2024
@emankov emankov added the feature Feature request or implementation label Aug 14, 2024
@emankov
Copy link
Collaborator

emankov commented Aug 14, 2024

Hello @foreverlms,

Currently, HIP supports some of the fp8 data types and APIs. Whereas, HIPIFY tools don't. Thank you for pointing it out.

Marking the ticket as a feature to Implement.

@emankov emankov changed the title [HIPIFY]: Does hipify support fp8 data type? [HIPIFY] Support for fp8 data types Aug 14, 2024
@emankov emankov changed the title [HIPIFY] Support for fp8 data types [HIPIFY][feature] Support for fp8 data types Aug 14, 2024
@foreverlms
Copy link
Author

Thanks for replying. Hope to see the fp8 support available.

@emankov emankov added the device device API-related label Nov 20, 2024
emankov added a commit to emankov/HIPIFY that referenced this issue Nov 20, 2024
@emankov
[HIPIFY][ROCm#1617][fp8] Support for fp8 math - Part 1
18eefd3 
+ Updated the regenerated `hipify-perl` and `BLAS` `CUDA2HIP` docs accordingly
+ [ToDo] Tests for all device API
emankov added a commit that referenced this issue Nov 20, 2024
@emankov
Merge pull request #1763 from emankov/HIPIFY
fa8213f 
[HIPIFY][#1617][fp8] Support for `fp8` math - Part 1
emankov added a commit to emankov/HIPIFY that referenced this issue Nov 21, 2024
@emankov
[HIPIFY][ROCm#1617][fp8] Support for fp8 math - Part 2 - Functions
83f64c9 
+ Updated the regenerated `hipify-perl` and `Device` `CUDA2HIP` docs accordingly
+ [ToDo] Tests for all Device API
emankov added a commit that referenced this issue Nov 21, 2024
@emankov
Merge pull request #1764 from emankov/HIPIFY
4359fe1 
[HIPIFY][#1617][fp8] Support for `fp8` math - Part 2 - Functions
emankov added a commit to emankov/HIPIFY that referenced this issue Nov 22, 2024
@emankov
[HIPIFY][ROCm#1617][fp8][tests] Support for fp8 math - Part 3 - Tests
76c63d9 
+ Added missing header files mapping
+ Updated the regenerated `hipify-perl`
+ [MISC] Minor fixes in the rest of synthetic tests
emankov added a commit that referenced this issue Nov 22, 2024
@emankov
Merge pull request #1765 from emankov/HIPIFY
6ad509b 
[HIPIFY][#1617][fp8][tests] Support for `fp8` math - Part 3 - Tests - Data Types
emankov added a commit to emankov/HIPIFY that referenced this issue Nov 26, 2024
@emankov
[HIPIFY][ROCm#1617][fp8][tests] Support for fp8 math - Part 4 - final
1635f1c 
+ [fix] Took `CUDA_DEVICE_FUNCTION_MAP` into account
  - The reason for not including them yet was that all the CUDA device functions had the same signatures in HIP
  - [Side Effect] `hipify-perl` became fatter and slower
  - [ToDo] Do not include identical signatures in the `hipify-perl` code
  - [ToDo] Minimize `hipify-perl` code AMAP
  - [ToDo] `fp16`
+ Added a few `fp16` types used with `fp8` APIs
+ Updated the regenerated `hipify-perl` and `Device` `CUDA2HIP` docs accordingly
emankov added a commit that referenced this issue Nov 26, 2024
@emankov
Merge pull request #1768 from emankov/HIPIFY
80ac36e 
[HIPIFY][#1617][fp8][tests] Support for `fp8` math - Part 4 - final
@emankov
Copy link
Collaborator

emankov commented Nov 26, 2024

Finally implemented.

@emankov emankov closed this as completed Nov 26, 2024
@emankov
Copy link
Collaborator

emankov commented Nov 26, 2024

Thanks for replying. Hope to see the fp8 support available.

Hi @foreverlms,

It is available now. Going to revise fp16 soon.

@foreverlms
Copy link
Author

Thanks for replying. Hope to see the fp8 support available.

Hi @foreverlms,

It is available now. Going to revise fp16 soon.

Thanks, this could be very helpful for mix300 series.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@emankov emankov

Labels
device device API-related feature Feature request or implementation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@emankov @foreverlms