Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial setup #4

Merged
merged 28 commits into from
Jun 11, 2024
Merged

Initial setup #4

merged 28 commits into from
Jun 11, 2024

Conversation

AlexAxthelm
Copy link
Contributor

@AlexAxthelm AlexAxthelm commented Jun 3, 2024 •
edited
Loading

Setup core workflow mechanics

  • Accept JSON params
  • Run workflow pacta
  • run workflow pacta report

NOTE: Does not run R CMD CHECK on windows-latest

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 3, 2024 •
edited
Loading

Docker build status

commit_time git_sha image
2024-06-11T16:29:43Z 19ea9cd ghcr.io/rmi-pacta/workflow.pacta.webapp:pr-4

@AlexAxthelm AlexAxthelm self-assigned this Jun 10, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 11, 2024 •
edited
Loading

Report Links

commit_time git_sha config report summary image
2024-06-11T16:29:43Z 19ea9cd full_params_2022Q4 Report Summary ghcr.io/rmi-pacta/workflow.pacta.webapp:pr-4
2024-06-11T16:29:43Z 19ea9cd full_params_2023Q4 Report Summary ghcr.io/rmi-pacta/workflow.pacta.webapp:pr-4

@AlexAxthelm AlexAxthelm mentioned this pull request Jun 11, 2024
Open
@AlexAxthelm AlexAxthelm marked this pull request as ready for review June 11, 2024 16:36
@AlexAxthelm AlexAxthelm requested review from cjyetman and jdhoffa June 11, 2024 16:36
@AlexAxthelm
Copy link
Contributor Author

Notes for reviewers: This is an MVP checkpoint. The next big step will be harmonizing this, workflow.pacta, and workflow.pacta.report to use the same schemas (or more accurately, sub/supersets of each other), but that's best done by opening up a triplet PR across the 3 repos, and modfiying them simultaneously.

jdhoffa
jdhoffa approved these changes Jun 11, 2024
View reviewed changes
Copy link
Member

@jdhoffa jdhoffa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NB comments, but looks great

.github/workflows/docker.yml
Comment on lines +26 to +29
# - default_2022Q4
# - default_2023Q4
- full_params_2022Q4
- full_params_2023Q4
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NB: What's the difference between default_* and full_params_*?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The default_*s use the inherit key (which should be the main mechanism), but that isn't setup in this repo yet (so they're commented out). the full_ ones send what should be the same parameters after the param inheritance process runs, but does it all as raw JSON input.

The corresponding directory in workflow.pacta give a pretty good idea.

docker-compose.yml Show resolved Hide resolved
@AlexAxthelm AlexAxthelm mentioned this pull request Jun 11, 2024
Open
@AlexAxthelm AlexAxthelm merged commit 1219971 into main Jun 11, 2024
22 checks passed
@AlexAxthelm AlexAxthelm deleted the initial-setup branch June 11, 2024 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdhoffa jdhoffa jdhoffa approved these changes

@cjyetman cjyetman Awaiting requested review from cjyetman

Assignees

@AlexAxthelm AlexAxthelm

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AlexAxthelm @jdhoffa