Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adopt options to run audit-only #33

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

AlexAxthelm
Copy link
Contributor

@AlexAxthelm AlexAxthelm commented Dec 17, 2024

Alternate to #32

Explictly pass a commands object as part of the JSON params, with audit, analysis, and reporting keys (all boolean), to determine which phases of the process run.

After this PR, the params object (usually passed via command line arg to the docker image) should have a top-level object commands:

"commands": {
  "audit": true,
  "analysis": false,
  "report": false
},
<rest of params>

In the above example, the audit would run (generating an audit file at $ANALYSIS_OUTPUT_DIR), but the actual analysis and interactive report generation phases would not.

By default, these commands are all true.

Depends on:

Copy link

github-actions bot commented Dec 17, 2024

Docker build status

commit_time git_sha image
2024-12-17T15:05:14Z e298f99 ghcr.io/rmi-pacta/workflow.pacta.webapp:pr-33

Copy link

github-actions bot commented Dec 17, 2024

Report Links

commit_time git_sha config report summary image
2024-12-17T15:05:14Z e298f99 audit_2022Q4 Report ghcr.io/rmi-pacta/workflow.pacta.webapp:pr-33
2024-12-17T15:05:14Z e298f99 audit_2023Q4 Report ghcr.io/rmi-pacta/workflow.pacta.webapp:pr-33
2024-12-17T15:05:14Z e298f99 default_2022Q4 Report ghcr.io/rmi-pacta/workflow.pacta.webapp:pr-33
2024-12-17T15:05:14Z e298f99 default_2023Q4 Report ghcr.io/rmi-pacta/workflow.pacta.webapp:pr-33
2024-12-17T15:05:14Z e298f99 full_params_2022Q4 Report ghcr.io/rmi-pacta/workflow.pacta.webapp:pr-33
2024-12-17T15:05:14Z e298f99 full_params_2023Q4 Report ghcr.io/rmi-pacta/workflow.pacta.webapp:pr-33

@AlexAxthelm AlexAxthelm mentioned this pull request Dec 17, 2024
5 tasks
@AlexAxthelm AlexAxthelm requested a review from jdhoffa December 17, 2024 15:17
@AlexAxthelm AlexAxthelm marked this pull request as ready for review December 17, 2024 15:17
@AlexAxthelm
Copy link
Contributor Author

@jdhoffa Marking as in review, but note that I still need to update DESCRIPTION after the dependency PRs are merged in.

@jdhoffa
Copy link
Member

jdhoffa commented Dec 20, 2024

I will review this in January 😊
@AlexAxthelm please remind me in case I forget!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants